Update domain template for arm64 use case #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1806532 now fixed and this workaround not needed anymore. Also for some of aarch64 cpus there is no rdrand flag/feature which fails with following error during domain creation. ``` virError(Code=67, Domain=31, Message='unsupported configuration: unknown CPU feature: rdrand') ```
Both OCP/microshift bundles are created using uefi[0] so better to have the `efi` firmware enable by default. In case of aarch64 systems looks like it is required to have `acpi` feature otherwise it failed with following error. ``` virError(Code=67, Domain=10, Message='unsupported configuration: ACPI requires UEFI on this architecture') ``` [0] https://github.com/crc-org/snc/blob/master/tools.sh#L208
In previous commit `efi` firmware added which add the `<nvram />` to domain template and during the deleting the VM (which destroy => undefine) if fails with following error. ``` Code=55, Domain=10, Message='Requested operation is not valid: cannot undefine domain with nvram' ``` This patch make sure to have `DOMAIN_UNDEFINE_NVRAM` flag set during undefine the VM. - https://libvirt.org/html/libvirt-libvirt-domain.html#VIR_DOMAIN_UNDEFINE_NVRAM
praveenkumar
force-pushed
the
update_domain
branch
from
c9442bd to
d667128
Compare
cfergeau
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the following patches I can manage crc VM on arm64 and amd64 linux machines. I also need to add CI to build arm64 bits but in separate PR.