Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arm64 builds for Linux #117

Closed
praveenkumar opened this issue May 22, 2024 · 3 comments
Closed

Enable arm64 builds for Linux #117

praveenkumar opened this issue May 22, 2024 · 3 comments
Assignees

Comments

@praveenkumar
Copy link
Member

We should build and release arm64 bits for linux as well so that user who want to try arm64 crc linux binary should able to use it.

@cfergeau
Copy link

Since machine-driver-libvirt cannot be cross-built, the situation is better wrt our RPM builds than admin-helper and crc (see crc-org/admin-helper#53 for example).
We already build RPMs for multiple arches, and the binaries in these RPMs are for the correct arch.
So we only need to release arm64 binaries, they are already built correctly as far as I can tell.

The libvirt XML generated by machine-driver-libvirt may contain hardcoded x86-specific features though. This needs to be fixed if that is the case.

@praveenkumar
Copy link
Member Author

The libvirt XML generated by machine-driver-libvirt may contain hardcoded x86-specific features though. This needs to be fixed if that is the case.

Yes, we need to fix those.

@cfergeau
Copy link

cfergeau commented Jul 1, 2024

Fixed by #119

@cfergeau cfergeau closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants