Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: eth light client and relayer sepolia support #394

Merged
merged 69 commits into from
Mar 13, 2025
Merged

Conversation

gjermundgaraba
Copy link
Contributor

@gjermundgaraba gjermundgaraba commented Mar 11, 2025

Description

closes: #387
closes: #378


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba gjermundgaraba marked this pull request as ready for review March 13, 2025 00:31
@gjermundgaraba gjermundgaraba requested a review from srdtrk March 13, 2025 00:31
@gjermundgaraba
Copy link
Contributor Author

Fixed most issues, I think. Will do another pass tomorrow

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another pass. Looking better

Comment on lines +24 to +25
/// The block number at which the event was emitted.
pub block_number: Option<u64>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in a separate PR, we can have this stop being an option, and emit an error instead. If the log doesn't have a height, I somehow feel like the event hasn't been mined.

@srdtrk srdtrk linked an issue Mar 13, 2025 that may be closed by this pull request
4 tasks
Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@@ -469,6 +473,140 @@ func (s *RelayerTestSuite) ICS20TransferERC20TokenBatchedAckToEthTest(
}))
}

func (s *RelayerTestSuite) TestMultiPeriodClientUpdateToCosmos() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some CI for this. Let's create an issue to split e2e.yml and link it here

@srdtrk srdtrk linked an issue Mar 13, 2025 that may be closed by this pull request
4 tasks
@srdtrk srdtrk merged commit 537b47c into main Mar 13, 2025
63 checks passed
@srdtrk srdtrk deleted the gjermund/sepolia branch March 13, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use finalized_header instead of attested_header Add support for LightClientFinalityUpdate
2 participants