Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use finalized_header instead of attested_header #387

Closed
4 tasks
srdtrk opened this issue Mar 11, 2025 · 0 comments · Fixed by #394
Closed
4 tasks

Use finalized_header instead of attested_header #387

srdtrk opened this issue Mar 11, 2025 · 0 comments · Fixed by #394
Assignees
@gjermundgaraba
Labels
audit bug Something isn't working ethereum-light-client Issues related to the 08-wasm ethereum light client

Comments

@srdtrk
Copy link
Member

srdtrk commented Mar 11, 2025

Summary of Bug

In many places, we use attested header instead of the finalized header. Attested header must only be used to validate finalized header, and then should never be used!

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@srdtrk srdtrk added audit bug Something isn't working ethereum-light-client Issues related to the 08-wasm ethereum light client labels Mar 11, 2025
@srdtrk srdtrk mentioned this issue Mar 12, 2025
Merged
6 tasks
@srdtrk srdtrk linked a pull request Mar 13, 2025 that will close this issue
imp: eth light client and relayer sepolia support #394
Merged
6 tasks
@srdtrk srdtrk added this to IBC Mar 13, 2025
@github-project-automation github-project-automation bot moved this to Backlog in IBC Mar 13, 2025
@srdtrk srdtrk moved this from Backlog to In progress in IBC Mar 13, 2025
@srdtrk srdtrk moved this from In progress to In review in IBC Mar 13, 2025
@gjermundgaraba gjermundgaraba mentioned this issue Mar 13, 2025
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from In review to Done in IBC Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjermundgaraba gjermundgaraba

Labels
audit bug Something isn't working ethereum-light-client Issues related to the 08-wasm ethereum light client
Projects
IBC
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

imp: eth light client and relayer sepolia support cosmos/solidity-ibc-eureka
2 participants
@gjermundgaraba @srdtrk