Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use execution timestamp instead of slot timestamp #401

Merged
merged 10 commits into from
Mar 14, 2025

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Mar 12, 2025

Description

Checked that POS e2e passed

closes: #395


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (a4d1830) to head (8b57fe6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          14       14           
  Lines         740      740           
=======================================
  Hits          739      739           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srdtrk srdtrk marked this pull request as ready for review March 13, 2025 19:03
@srdtrk srdtrk requested a review from gjermundgaraba as a code owner March 13, 2025 19:03

new_consensus_state.timestamp = current_client_state
.compute_timestamp_at_slot(consensus_update.finalized_header.beacon.slot);
new_consensus_state.timestamp = consensus_update.finalized_header.execution.timestamp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs for this field needs to be updated, and the places we create consensus state as well (e2e + ethgenesis script)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated docs, scripts already use the correct timestamp

@gjermundgaraba gjermundgaraba merged commit da3a351 into main Mar 14, 2025
63 checks passed
@gjermundgaraba gjermundgaraba deleted the serdar/395-correct-timestamp branch March 14, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store the execution header's timestamp in the ConsensusState instead of beacon
2 participants