-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use execution timestamp instead of slot timestamp #401
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 14 14
Lines 740 740
=======================================
Hits 739 739
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
||
new_consensus_state.timestamp = current_client_state | ||
.compute_timestamp_at_slot(consensus_update.finalized_header.beacon.slot); | ||
new_consensus_state.timestamp = consensus_update.finalized_header.execution.timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs for this field needs to be updated, and the places we create consensus state as well (e2e + ethgenesis script)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated docs, scripts already use the correct timestamp
Description
Checked that POS e2e passed
closes: #395
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.