-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement multi header support #443
base: main
Are you sure you want to change the base?
Conversation
Note that our test format currently does not support multiple headers with the same name, because we use a map for headers. In the future we should use a list instead in order to allow for repeating headers and values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this. Big change.
I'll suggest you to split in 3 PRs, as we are mixing stuff here.
- All the zerolog changes (🙏 good catch). E.g. inclusion and initialization.
func (s *responseTestSuite) SetupSuite() {
zerolog.SetGlobalLevel(zerolog.Disabled)
}
- The uncommented
self_updater
tests - This PR, rebased after the above.
It will make things more clear if we need to revert something.
411541d
to
d98119c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like tests are broken?
1a6f1cc
to
26d8018
Compare
05f2e83
to
1c56f65
Compare
aa265ca
to
73be30d
Compare
Extended PR with updated schema and support for new |
- support multiple headers with the same name - support multiple headers with identical name and value - make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request - improve API, tests, and documentation of ftwhttp.Header - disable logging in tests where possible - enable self-updater test (go-critic was complaining because the test file was touched) Fixes coreruleset#332
73be30d
to
44c74d6
Compare
support multiple headers with the same name
support multiple headers with identical name and value
make list of headers ordered; in the future, tests should be able to enforce the order of headers in a request
improve API, tests, and documentation of ftwhttp.Header
disable logging in tests where possible
enable self-updater test (go-critic was complaining because the test file was touched)
Fixes #332