Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate Headers for OrderedHeaders #37

Merged

Conversation

theseion
Copy link
Collaborator

Required for proper multi value header support in go-ftw (coreruleset/go-ftw#443).

@theseion theseion requested a review from fzipi February 15, 2025 12:40
@fzipi
Copy link
Member

fzipi commented Feb 15, 2025

Why not making them always ordered?

@theseion
Copy link
Collaborator Author

That's the point. Headers is a map, so unordered and doesn't allow for duplicates. We need to keep Header for backwards compatibility though and I'm not aware of any mechanism that would allow us to easily accept both a list or a map for the same struct type.

@theseion
Copy link
Collaborator Author

@fzipi Anything you want to add?

@fzipi
Copy link
Member

fzipi commented Feb 16, 2025

No, go ahead and merge.

@theseion theseion merged commit 4680217 into coreruleset:main Feb 17, 2025
1 check passed
@theseion theseion deleted the replace-headers-with-ordered-headers branch February 17, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants