Add support for riscv #4079
Open
Add support for riscv #4079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dustymabe
force-pushed
the
dusty-riscv-support
branch
from
006d5ba to
afea0d8
Compare
The reason we build kolet for other architectures is so that we can mix architectures with test initiators and test runners. i.e. i.e. x86_64 kola running in the pipeline testing against an aarch64 EC2 instance. This use case isn't too common so let's just not build kolet for all the different architectures on every architecture. We'll special case for x86_64 here and let it build for them all, but for the rest we just build for the architecture that the container build is for.
This is initial support for being able to build against a riscv64 architecture target. xref: coreos/fedora-coreos-tracker#1931
This fails with a symbol error. Error reported upstream in golang/go#72840
dustymabe
force-pushed
the
dusty-riscv-support
branch
from
afea0d8 to
2136693
Compare
jlebon
reviewed
Apr 25, 2025
| # This is mainly so we can initiate tests against a remote that is | ||
| # a different architecture. i.e. x86_64 kola testing against an | ||
| # aarch64 EC2 instance. | ||
| KOLET_ARCHES=aarch64 ppc64le s390x x86_64 |
| @@ -73,7 +79,7 @@ mantle: $(MANTLE_BINARIES) kolet | |||
|
|
|||
| .PHONY: $(MANTLE_BINARIES) kolet | |||
| $(MANTLE_BINARIES) kolet: | |||
| mantle/build cmd/$(basename $@) | |||
| KOLET_ARCHES="$(KOLET_ARCHES)" mantle/build cmd/$(basename $@) | |||
There was a problem hiding this comment.
Hmm weird, that shouldn't be necessary. It should just get passed through.
| @@ -11,7 +11,8 @@ if [[ $# -eq 0 ]]; then | |||
| fi | |||
|
|
|||
| declare -A BASEARCH_TO_GOARCH=([s390x]=s390x [x86_64]=amd64 [aarch64]=arm64 [ppc64le]=ppc64le) | |||
| KOLET_ARCHES="${KOLET_ARCHES:-s390x x86_64 aarch64 ppc64le}" | |||
| ARCH=$(arch) | |||
| KOLET_ARCHES="${KOLET_ARCHES:-$(ARCH)}" | |||
There was a problem hiding this comment.
Invalid syntax I think? Also feels like we can just keep that as one line.
There was a problem hiding this comment.
Will fix in next upload. Not sure what you mean by keep it as one line.
I use the $ARCH var later in the script.
| local cgo_override="${CGO_ENABLED:-}" | ||
| [ "${ARCH}" == "riscv64" ] && cgo_override=0 | ||
|
|
||
| CGO_ENABLED=${cgo_override} \ |
There was a problem hiding this comment.
It's not clear from quickly looking at the golang docs what CGO_ENABLED= go build ... will do. I think it'd be easier to review if we just only set the env on riscv64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial support for being able to build against a riscv64
architecture target.
xref: coreos/fedora-coreos-tracker#1931
There is also a commit in here for limiting the number of architectures we
build
koletfor by default. See the commit message for more details.