Skip to content

Fix react-hook-form task 153: handleSubmit 3rd arg type mismatch with test #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akhatua2 merged 1 commit into from
Mar 21, 2026
Merged

Fix react-hook-form task 153: handleSubmit 3rd arg type mismatch with test #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions dataset/react_hook_form_task/task153/combined.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,22 @@ diff --git a/src/logic/createFormControl.ts b/src/logic/createFormControl.ts
index f7079332..4fa17575 100644
--- a/src/logic/createFormControl.ts
+++ b/src/logic/createFormControl.ts
@@ -1097,7 +1097,8 @@ export function createFormControl<
@@ -1097,7 +1097,13 @@ export function createFormControl<
};

const handleSubmit: UseFormHandleSubmit<TFieldValues> =
- (onValid, onInvalid) => async (e) => {
+ (onValid, onInvalid, options) => async (e?, context?) => {
+ (onValid, onInvalid, optionsOrOnFinally) => async (e?, context?) => {
+ // Accept onFinally as a bare function (3rd positional arg) or as
+ // options.onFinally for backward compatibility with both call styles.
+ const options = typeof optionsOrOnFinally === 'function'
+ ? { onFinally: optionsOrOnFinally }
+ : optionsOrOnFinally;
+ let onValidError: Error | undefined = undefined;
if (e) {
e.preventDefault && e.preventDefault();
e.persist && e.persist();
@@ -1108,36 +1109,107 @@ export function createFormControl<
@@ -1108,36 +1114,107 @@ export function createFormControl<
isSubmitting: true,
});

Expand Down Expand Up @@ -182,7 +187,7 @@ index 2f20133e..c07f7e4a 100644
- onInvalid?: SubmitErrorHandler<TFieldValues>,
-) => (e?: React.BaseSyntheticEvent) => Promise<void>;
+ onInvalid?: SubmitErrorHandler<TFieldValues, TSubmitContext>,
+ options?: {
+ optionsOrOnFinally?: ((formState: FormState<TFieldValues>) => void | Promise<void>) | {
+ onBeforeValidate?: (data: TFieldValues) => Promise<void> | void;
+ onAfterValidate?: (errors: FieldErrors<TFieldValues>, data: TFieldValues) => Promise<void> | void;
+ preventFocusOnError?: boolean;
Expand Down
Loading