Fix react-hook-form task 153: handleSubmit 3rd arg type mismatch with test#41
Merged
akhatua2 merged 1 commit intocooperbench:mainfrom Mar 21, 2026
Conversation
The combined.patch uses handleSubmit(onValid, onInvalid, options) where
options is an object, but the test patch passes onFinally as a bare
function in the 3rd positional argument. Since the implementation checks
options?.onFinally and options is a function (not an object), onFinally
is never invoked and all 3 onFinally tests fail.
Add runtime type detection to accept both call styles:
handleSubmit(valid, invalid, onFinallyFn) -- bare function
handleSubmit(valid, invalid, { onFinally: fn }) -- options object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combined.patchchangeshandleSubmitsignature to(onValid, onInvalid, options)whereoptionsis an object{ onFinally?: ..., onBeforeValidate?: ..., ... }tests2.patch) passesonFinallyas a bare function in the 3rd positional argument:handleSubmit(onValidCallback, onInvalidCallback, onFinallyCallback)options?.onFinally, andoptionsis actually a function (not an object),onFinallyis never invokedonFinallytests fail with "Expected 1 calls, received 0 calls"Fix
Add runtime type detection for the 3rd argument in
combined.patch:This accepts both
handleSubmit(valid, invalid, onFinallyFn)andhandleSubmit(valid, invalid, { onFinally: fn, ... }). The TypeScript type definition is updated to match.Test plan