Skip to content

Add a workspace #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2025
Merged

Add a workspace #294

merged 4 commits into from
Jul 11, 2025

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented Apr 9, 2025

This PR adds a workspace to the repo to simplify dependency management and crate publishing.

@Tim-Zhang
Copy link
Member

Hi, @jprendes. There are commits which has already been merged in the PR, please remove them, thanks.

jprendes added 4 commits May 20, 2025 20:52
Add a cargo workspace that links all the crates in the project together.
This should make publishing easier when "package-workspace" stabilises.

Signed-off-by: Jorge Prendes <[email protected]>
Skip running rustfmt on the code generated by the examples

Signed-off-by: Jorge Prendes <[email protected]>
add publish = false to ttrpc-example to avoid publishing it by mistake

Signed-off-by: Jorge Prendes <[email protected]>
Add RELEASE.md with release intructions

Signed-off-by: Jorge Prendes <[email protected]>
@jprendes
Copy link
Contributor Author

rebased

@jprendes
Copy link
Contributor Author

@Tim-Zhang PTAL :-)

@jprendes
Copy link
Contributor Author

@Tim-Zhang @lifupan are we still interested in having a workspace?
If not, could we have a 0.9 release including the changes from #290 ?

Copy link
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jprendes Sorry for my late reply, We are very interested in this and this is a good pr, thank you

@lifupan lifupan merged commit 05bd047 into containerd:master Jul 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants