Skip to content

Bump crate versions #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

Bump crate versions #295

merged 5 commits into from
Jul 15, 2025

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented Apr 9, 2025

This PR bumps the crate versions for publishing.
The compiler crate needs a major version bump after breaking changes introduced by PR #291
The codegen crate needs a major version bump because it re-exports ttrpc_compiler::Customize.
The main crate needs a major version bump after the breaking changes introduced by PR #290

This PR builds on top of #294: Diff excluding the changes in #294
I'll rebase once #294 is merged

@Tim-Zhang
Copy link
Member

Hi, @jprendes. There are commits which has already been merged in the PR, please remove them, thanks.

jprendes added 5 commits May 20, 2025 20:52
Add a cargo workspace that links all the crates in the project together.
This should make publishing easier when "package-workspace" stabilises.

Signed-off-by: Jorge Prendes <[email protected]>
Skip running rustfmt on the code generated by the examples

Signed-off-by: Jorge Prendes <[email protected]>
add publish = false to ttrpc-example to avoid publishing it by mistake

Signed-off-by: Jorge Prendes <[email protected]>
Add RELEASE.md with release intructions

Signed-off-by: Jorge Prendes <[email protected]>
Bump crate versions for publishing.
The compiler crate needs a major version bump after breaking changes introduced by PR containerd#291
The codegen crate needs a major version bump because it exports an item from the compiler crate.
The main crate needs a major version bump after the braking changes introduced by PR containerd#290

Signed-off-by: Jorge Prendes <[email protected]>
@jprendes
Copy link
Contributor Author

rebased, but this PR is still waiting for #294 to be merged.

@jprendes
Copy link
Contributor Author

There's an unrelated test failure

thread 'main' panicked at example/./async-client.rs:38:9:
assertion `left == right` failed
  left: Err(RpcStatus(Status { code: DEADLINE_EXCEEDED, message: "timeout", details: [], special_fields: SpecialFields { unknown_fields: UnknownFields { fields: None }, cached_size: CachedSize { size: 0 } } }))
 right: Err(Others("Receive packet timeout Elapsed(())"))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Looks like 2 slightly different versions of the same error.

@Tim-Zhang
Copy link
Member

thread 'main' panicked at example/./async-client.rs:38:9:

I will ignore the unrelated failed CI and force merge this pr later

Copy link
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Tim-Zhang Tim-Zhang merged commit f31f592 into containerd:master Jul 15, 2025
7 of 10 checks passed
@Tim-Zhang
Copy link
Member

Tim-Zhang commented Jul 15, 2025

@jprendes
Copy link
Contributor Author

Thanks @Tim-Zhang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants