-
Notifications
You must be signed in to change notification settings - Fork 60
Bump crate versions #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump crate versions #295
Conversation
Hi, @jprendes. There are commits which has already been merged in the PR, please remove them, thanks. |
Add a cargo workspace that links all the crates in the project together. This should make publishing easier when "package-workspace" stabilises. Signed-off-by: Jorge Prendes <[email protected]>
Skip running rustfmt on the code generated by the examples Signed-off-by: Jorge Prendes <[email protected]>
add publish = false to ttrpc-example to avoid publishing it by mistake Signed-off-by: Jorge Prendes <[email protected]>
Add RELEASE.md with release intructions Signed-off-by: Jorge Prendes <[email protected]>
Bump crate versions for publishing. The compiler crate needs a major version bump after breaking changes introduced by PR containerd#291 The codegen crate needs a major version bump because it exports an item from the compiler crate. The main crate needs a major version bump after the braking changes introduced by PR containerd#290 Signed-off-by: Jorge Prendes <[email protected]>
rebased, but this PR is still waiting for #294 to be merged. |
There's an unrelated test failure
Looks like 2 slightly different versions of the same error. |
I will ignore the unrelated failed CI and force merge this pr later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Thanks @Tim-Zhang ! |
This PR bumps the crate versions for publishing.
The compiler crate needs a major version bump after breaking changes introduced by PR #291
The codegen crate needs a major version bump because it re-exports
ttrpc_compiler::Customize
.The main crate needs a major version bump after the breaking changes introduced by PR #290
This PR builds on top of #294: Diff excluding the changes in #294
I'll rebase once #294 is merged