-
-
Notifications
You must be signed in to change notification settings - Fork 237
feat: handle singularity/apptainer sandbox images #2166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: handle singularity/apptainer sandbox images #2166
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2166 +/- ##
==========================================
- Coverage 85.10% 77.44% -7.66%
==========================================
Files 46 46
Lines 8358 8380 +22
Branches 1951 1955 +4
==========================================
- Hits 7113 6490 -623
- Misses 779 1370 +591
- Partials 466 520 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you @natthan-pigoux ; can you run |
|
@mr-c , thank you to already have a look. I will be away next week, so I will probably not answer before 2nd November. |
4cae634 to
cf7c0fa
Compare
feat: handle local singularity sandbox image fix: skip searching if singularity inspect found image improve singularity inspect test: add test for singularity sandbox image remove unused normalization add comment
cf7c0fa to
6bd825b
Compare
08cd438 to
c51d312
Compare
35a7346 to
6f96b54
Compare
|
@mr-c , sorry I should have put this PR as Draft before ... but now it should be ready for review. The tests should cover quiet well the changes. |
Running
cwltoolwithdockerRequirements(with pull disabled) using a local Singularity/Apptainer sandbox image is not currently handle.cwltoolis only searching for files (e.g. sif images) and not path as it should for sandbox images.Here I provide:
singularity inspectto verify that a path is a singularity imageget_imagemethoddockerPullSome questions I have:
candidatessearch, I don't know if we wish thatsingularity inspectis strong enough to ensure the presence of the imageIt is the first time I contribute here so I might have miss some things :)
closes #2165