refactor: inspect_image test

Author: natthan-pigoux

tests/test_singularity.py

@@ -1,5 +1,6 @@
 """Tests to find local Singularity image."""
 
+import json
 import shutil
 import subprocess
 from pathlib import Path
@@ -194,18 +195,13 @@ def test_singularity_local_sandbox_image(tmp_path: Path):
         else:
             pytest.skip(f"Failed to build the singularity image: {build.stderr}")
 
-
 @needs_singularity
 def test_singularity_inspect_image(tmp_path: Path, monkeypatch: pytest.MonkeyPatch):
     workdir = tmp_path / "working_dir"
     workdir.mkdir()
     repo_path = workdir / "container_repo"
     image_path = repo_path / "alpine"
 
-    # test path does not exists
-    res_inspect = _inspect_singularity_image(str(image_path))
-    assert res_inspect is False
-
     # test image exists
     repo_path.mkdir()
     cmd = [
@@ -217,14 +213,34 @@ def test_singularity_inspect_image(tmp_path: Path, monkeypatch: pytest.MonkeyPat
     ]
     build = subprocess.run(cmd, capture_output=True, text=True)
     if build.returncode == 0:
-        # Verify the path is a container image
+        # Verify the path is a correct container image
         res_inspect = _inspect_singularity_image(image_path)
         assert res_inspect is True
 
-    # test wrong subprocess call
+        # test wrong json output
+        def mock_subprocess_run(*args, **kwargs):
+            class Result:
+                returncode = 0
+                stdout = "not-json"
+            return Result()
+
+        monkeypatch.setattr("cwltool.singularity.run", mock_subprocess_run)
+        res_inspect = _inspect_singularity_image(image_path)
+        assert res_inspect is False
+    else:
+        pytest.skip(f"singularity sandbox image build didn't worked: {build.stderr}")
+
+def test_singularity_sandbox_image_not_exists():
+    image_path = "/tmp/not_existing/image"
+    res_inspect = _inspect_singularity_image(image_path)
+    assert res_inspect is False
+
+
+def test_inspect_image_wrong_sb_call(monkeypatch: pytest.MonkeyPatch):
+
     def mock_failed_subprocess(*args, **kwargs):
         raise subprocess.CalledProcessError(returncode=1, cmd=args[0])
 
     monkeypatch.setattr("cwltool.singularity.run", mock_failed_subprocess)
-    res_inspect = _inspect_singularity_image(str(image_path))
+    res_inspect = _inspect_singularity_image("/tmp/container_repo/alpine")
     assert res_inspect is False