-
Notifications
You must be signed in to change notification settings - Fork 53
chore: various backports to 7.2 #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes the test `#test_all_foreign_keys_valid_having_foreign_keys_in_multiple_schemas`.
Avoid 87% of the `#disable_referential_integrity` calls made in fixture setup by just trying first without disabling and just disabling in case of failure. Also batch foreign keys removals and addition (for clarity only).
This fixes regional related parts, hence fixes #344
5bbf70f
to
7e4c2b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
It appears there is one test with an issue though:
|
There was also an issue on the company table related test (pretty sure it is just because of tests changing the db state). I'm investigating on the timeout but I cannot reproduce it locally yet EDIT: I had one local reproduction of the fairness test, but only with the whole test suite. I also suspect that we leek one checkout connection at some point in the test suite. I'll investigate further, but I believe this is not directly related to 7.2 (I'm running tests on the master branch to confirm) |
I have very few reproductions, I suggest merging to avoid this being stale, and I'll run tests on fairness for the master (could we consider call it main? 🙏). WDYT? I would rebase and merge to keep backport history if you don't mind |
Cherry-pick #364 for
7-2-stable
branch. I took the opportunity to include the backport already made to7-0-stable
branch and all of the backports that are test related so we can enjoy a faster CI here as well.