Skip to content

fix: transaction state on rollback (#364) #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 7-1-stable
Choose a base branch
from

Conversation

BuonOmo
Copy link
Collaborator

@BuonOmo BuonOmo commented Mar 6, 2025

Fixes #258

See #368

@BuonOmo BuonOmo requested a review from rafiss March 6, 2025 12:38
@rafiss
Copy link
Contributor

rafiss commented Mar 17, 2025

I'm not quite sure why this error happened in the v23.2 test:

 /home/runner/work/activerecord-cockroachdb-adapter/activerecord-cockroachdb-adapter/vendor/bundle/ruby/3.5.0+0/bundler/gems/rails-f926c7902969/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:55:in 'PG::Connection#exec': PG::FeatureNotSupported: ERROR:  at or near "before_insert_trigger": syntax error: unimplemented: this syntax (ActiveRecord::StatementInvalid)
DETAIL:  source SQL:
CREATE TRIGGER before_insert_trigger

v23.2 does not support triggers, but I'm surprised the test tried using one on that version.

@BuonOmo
Copy link
Collaborator Author

BuonOmo commented Mar 20, 2025

@rafiss yeah I didn't cherry pick everything on that one, I believe I should as well. I wanted to first focus on the 7-2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants