-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DSL operator codegen #25
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
af45b32
to
fbdeccf
Compare
fbdeccf
to
5066787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this would conflict with #26 and need to decide who merges first
@@ -31,15 +31,6 @@ Logical Join( | |||
schema_len = left.schema_len + right.schema_len | |||
} | |||
|
|||
Logical Sort(child: Logical, keys: [(Scalar, String)]) derive { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider support block comments in the language?
Problem
The query optimizer needs to generate type-safe Rust code for various logical and scalar operators. Manually writing these operators is error-prone and makes it difficult to maintain consistency across the codebase.
Summary of changes
Added code generation support for logical and scalar operators:
Core Code Generation
Value
,Relation
,Scalar
)Generated Components (among others)
Example Usage
Input DSL:
Generated code (among others):