-
Notifications
You must be signed in to change notification settings - Fork 10
feat: DSL parser rewrite #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
af45b32 to
fbdeccf
Compare
fbdeccf to
5066787
Compare
skyzh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this would conflict with #26 and need to decide who merges first
| @@ -31,15 +31,6 @@ Logical Join( | |||
| schema_len = left.schema_len + right.schema_len | |||
| } | |||
|
|
|||
| Logical Sort(child: Logical, keys: [(Scalar, String)]) derive { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider support block comments in the language?
| | New with | ||
| | Document | ||
| | Project | ||
| \\ Template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Consider using raw string, i.e. `r#""# so we don't have to escape things.
Problem
The previous parser was imperative, had poorly defined syntax, was missing the entire physical side, and was not maintainable (essentially a hackathon-like POC). This PR solves all of these problems by designing a better language and using a declarative parser.
Summary of changes
Next steps