-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NANOAOD] Add missing trigger filter bits #47594
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47594/44090
|
A new Pull Request was created by @hqucms for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable nano |
please test |
+1 Size: This PR adds an extra 68KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47594/44095 |
Pull request #47594 was updated. @ftorrresd, @hqucms can you please check and sign again. |
+1 Size: This PR adds an extra 68KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47594/44098 |
Pull request #47594 was updated. @ftorrresd, @hqucms can you please check and sign again. |
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
PR description:
This PR adds missing trigger filter bits (mostly for the
ParkingVBF
andParkingHH
HLT paths) in 2024 datasets, based on the report from https://cms-talk.web.cern.ch/t/additional-nanoaod-trigger-filter-bits/118040.To be able to store more than 32 filter bits, the data type of
TrigObj_filterBits
is changed fromInt_t
toULong64_t
.Further updates:
Jet
trigobjs needed by JMEElectron
trigobjs as reported on https://cms-talk.web.cern.ch/t/additional-nanoaod-trigger-filter-bits/118040/9PR validation:
runTheMatrix.py -w nano --ibeos -l 2500.311
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 15_0_X for MiniAODv6+NanoAODv15 campaign.