Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15_0_X] [NANOAOD] Add missing trigger filter bits #47601

Open
wants to merge 6 commits into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Mar 14, 2025

Backport of #47594

PR description:

This PR adds missing trigger filter bits (mostly for the ParkingVBF and ParkingHH HLT paths) in 2024 datasets, based on the report from https://cms-talk.web.cern.ch/t/additional-nanoaod-trigger-filter-bits/118040.

To be able to store more than 32 filter bits, the data type of TrigObj_filterBits is changed from Int_t to ULong64_t.

Further updates:

PR validation:

runTheMatrix.py -w nano --ibeos -l 2500.311

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 15_0_X for MiniAODv6+NanoAODv15 campaign.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2025

A new Pull Request was created by @hqucms for CMSSW_15_0_X.

It involves the following packages:

  • DataFormats/NanoAOD (xpog)
  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@gpetruc, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2025

cms-bot internal usage

@hqucms
Copy link
Contributor Author

hqucms commented Mar 14, 2025

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented Mar 14, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6217/44986/summary.html
COMMIT: 1a0715b
CMSSW: CMSSW_15_0_X_2025-03-14-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47601/44986/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1792 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4018889
  • DQMHistoTests: Total failures: 267
  • DQMHistoTests: Total nulls: 80
  • DQMHistoTests: Total successes: 4018522
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 93.06000000000006 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 4.230 KiB Physics/NanoAODDQM
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 265 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 110 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 89951
  • DQMHistoTests: Total failures: 230
  • DQMHistoTests: Total nulls: 94
  • DQMHistoTests: Total successes: 89627
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 50.76000000000002 KiB( 22 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 4.230 KiB Physics/NanoAODDQM
  • Checked 113 log files, 65 edm output root files, 23 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.110 3.110 -0.001 ( -0.0% ) 6.63 5.96 +11.2% 2.589 2.583
2500.002 3.226 3.227 -0.000 ( -0.0% ) 6.27 5.36 +17.0% 3.005 3.022
2500.003 3.167 3.167 -0.000 ( -0.0% ) 6.55 5.60 +17.1% 2.992 2.994
2500.011 1.642 1.642 0.000 ( +0.0% ) 11.94 9.61 +24.3% 2.652 2.661
2500.012 2.180 2.180 0.000 ( +0.0% ) 6.58 5.62 +17.1% 2.837 2.845
2500.013 1.997 1.997 0.000 ( +0.0% ) 9.33 7.72 +20.9% 2.759 2.754
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.97 1.84 +7.2% 2.680 2.678
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.92 1.77 +8.4% 2.671 2.678
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.86 1.72 +8.0% 2.530 2.549
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.51 1.42 +6.8% 2.769 2.787
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.72 1.60 +7.3% 2.723 2.751
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.73 1.61 +7.3% 2.700 2.700
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.66 1.53 +8.4% 2.764 2.775
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.66 1.55 +7.3% 2.750 2.762
2500.101 2.869 2.850 0.019 ( +0.7% ) 16.21 12.96 +25.1% 2.603 2.637
2500.111 1.469 1.469 -0.000 ( -0.0% ) 31.75 24.44 +29.9% 2.340 2.331
2500.112 1.891 1.889 0.002 ( +0.1% ) 25.61 21.02 +21.9% 2.404 2.403
2500.131 0.750 0.750 0.000 ( +0.0% ) 37.81 28.49 +32.7% 1.507 1.498
2500.201 2.701 2.679 0.022 ( +0.8% ) 13.42 9.99 +34.4% 2.206 2.205
2500.211 1.840 1.836 0.004 ( +0.2% ) 27.53 19.43 +41.7% 2.410 2.390
2500.212 2.238 2.233 0.005 ( +0.2% ) 22.83 17.43 +31.0% 2.497 2.491
2500.221 2.141 2.115 0.026 ( +1.2% ) 14.09 10.95 +28.7% 2.129 2.118
2500.222 3.511 3.487 0.025 ( +0.7% ) 13.08 9.60 +36.2% 2.220 2.210
2500.223 9.515 9.490 0.025 ( +0.3% ) 4.84 3.53 +37.2% 2.342 2.338
2500.224 6.629 6.604 0.025 ( +0.4% ) 1.26 1.06 +19.0% 2.336 2.340
2500.225 6.677 6.652 0.025 ( +0.4% ) 1.20 0.99 +20.6% 2.556 2.560
2500.226 3.206 3.180 0.025 ( +0.8% ) 13.63 9.82 +38.8% 2.217 2.216
2500.227 1.442 1.442 0.000 ( +0.0% ) 24.13 18.74 +28.7% 1.443 1.436
2500.228 4.038 3.996 0.042 ( +1.1% ) 9.09 7.94 +14.4% 2.316 2.314
2500.231 1.516 1.512 0.005 ( +0.3% ) 23.03 16.49 +39.7% 2.316 2.308
2500.232 2.497 2.493 0.004 ( +0.2% ) 21.21 16.24 +30.6% 2.406 2.397
2500.233 4.991 4.986 0.005 ( +0.1% ) 7.36 5.54 +32.8% 2.529 2.530
2500.234 3.924 3.919 0.005 ( +0.1% ) 1.64 1.37 +19.2% 2.473 2.486
2500.235 3.955 3.950 0.005 ( +0.1% ) 1.55 1.33 +16.3% 2.677 2.689
2500.236 2.287 2.282 0.005 ( +0.2% ) 21.98 15.88 +38.5% 2.396 2.390
2500.237 1.018 1.018 0.000 ( +0.0% ) 35.46 31.12 +14.0% 1.454 1.447
2500.238 2.473 2.469 0.004 ( +0.2% ) 17.57 15.71 +11.8% 2.482 2.481
2500.241 9.404 9.404 0.000 ( +0.0% ) 6.91 5.43 +27.2% 1.923 1.927
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.69 1.49 +14.0% 1.728 1.725
2500.243 2.712 2.712 0.000 ( +0.0% ) 16.78 13.67 +22.7% 1.062 1.060
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.16 1.00 +16.2% 1.678 1.691
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.54 1.36 +13.6% 1.691 1.692
2500.251 645.314 645.314 0.000 ( +0.0% ) 1.67 1.59 +4.8% 1.781 1.775
2500.301 0.021 0.021 0.000 ( +0.0% ) 1.83 1.68 +9.0% 2.790 2.795
2500.311 0.036 0.036 0.000 ( +0.0% ) 1.79 1.68 +7.0% 2.748 2.744
2500.901 1.819 1.819 0.000 ( +0.0% ) 45.77 40.88 +11.9% 1.443 1.446
2500.902 1.665 1.665 0.000 ( +0.0% ) 49.13 44.37 +10.7% 1.338 1.337
2500.911 14.345 14.345 0.000 ( +0.0% ) 8.48 7.68 +10.4% 1.091 1.084
2500.912 0.199 0.310 -0.111 ( -35.7% ) 2.66 2.35 +13.3% 0.850 0.846
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.69 2.51 +7.3% 0.852 0.850

@hqucms
Copy link
Contributor Author

hqucms commented Mar 14, 2025

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants