-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: temporarily revert the BTL numbering scheme update #47115
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47115/43326 |
A new Pull Request was created by @fabiocos for master. It involves the following packages:
@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-data/Geometry-TestReference#19 |
type fix |
type mtd |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+geometry |
+1 |
+1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 please look at cms-sw/cmsdist#9621 which should be used together this PR, avoiding to add useless extra payload in the cms-data GitHub just to go back to the previous situation (thanks to @smuzaffar for the action) |
+1 |
PR description:
Following the issue mentioned in #47114 as a consequence of the update of the BTL numbering scheme and
BTLDetId
data format in the PR #46977 , the update is temporarily reverted, pending a solution that protects against the residual backward compatibility violations.PR validation:
Simple revert of the PR without further developments on top of it, code compiles. It requires reverting also the data files used as references of the unit tests