Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTD Geometry: temporarily revert latest MTD unit test reference update #19

Merged
merged 1 commit into from
Jan 17, 2025
Merged

MTD Geometry: temporarily revert latest MTD unit test reference update #19

merged 1 commit into from
Jan 17, 2025

Conversation

fabiocos
Copy link
Contributor

This reverts commit 6830a59.

See cms-sw/cmssw#47114

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for branch master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2025 •
edited
Loading

cms-bot internal usage

@fabiocos fabiocos mentioned this pull request Jan 16, 2025
Merged
@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio: This PR was tested with cms-sw/cmssw#47115, please check if they should be merged together

@fabiocos
Copy link
Contributor Author

as discussed with @smuzaffar instead of merging this PR, a cmsdist revert of the commit to be reverted by this PR is being provided , see cms-sw/cmsdist#9621
This will avoid adding useless extra stuff to the GitHub repository

@smuzaffar smuzaffar mentioned this pull request Jan 17, 2025
Merged
@mandrenguyen
Copy link

+1

@mandrenguyen
Copy link

merge

@cmsbuild cmsbuild merged commit 3eab8aa into cms-data:master Jan 17, 2025
1 of 2 checks passed
@cmsbuild cmsbuild mentioned this pull request Jan 17, 2025
Merged
@smuzaffar
Copy link
Contributor

smuzaffar commented Jan 17, 2025 •
edited
Loading

this was replaced by cms-sw/cmsdist#9621 which I have now merged. I will force push changes to this repo to remove the extra commits/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-approved pending-signatures tests-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabiocos @cmsbuild @mandrenguyen @smuzaffar