-
Notifications
You must be signed in to change notification settings - Fork 189
chore: Upgrade eslint #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: Upgrade eslint #3509
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6cd9651
chore: Upgrade eslint
just-boris 5b5a23a
fix dependency upgrade issues
just-boris 1bf0df5
more dependency fixes
just-boris dd8887e
fix custom eslint rule tests
just-boris 6b449bf
fix jest/valid-title issues
just-boris 44ad2fa
fix date-range-picker tests
just-boris 58dea3c
undo changes
just-boris e3ba781
fix date-range-picker tests
just-boris 451e5eb
fix issues after rebase
just-boris d5e0438
more rebase conflicts
just-boris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
export * from '../components/lib/components'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ const ruleWildcardPath = [ | |
}, | ||
]; | ||
const defaultRules = [...ruleHardcodedPath, ...ruleWildcardPath]; | ||
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } }); | ||
const ruleTester = new RuleTester(); | ||
|
||
ruleTester.run('ban-files', banFiles, { | ||
valid: [ | ||
|
@@ -51,12 +51,6 @@ ruleTester.run('ban-files', banFiles, { | |
options: [ruleHardcodedPath], | ||
errors: [{ message: "Disallowed import 'src/index.ts' in favor of having smaller bundle sizes." }], | ||
}, | ||
{ | ||
code: 'import "../index"', | ||
filename: './src/button/index.tsx', | ||
options: [ruleHardcodedPath], | ||
errors: [{ message: "Disallowed import 'src/index.ts' in favor of having smaller bundle sizes." }], | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicated test. The new version detects and calls this out |
||
{ | ||
code: 'import "../button"', | ||
filename: './src/alert/index.tsx', | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated eslint captured all JS/TS files in our repo, not just
src