chore: Upgrade eslint #3509

just-boris · 2025-05-14T17:25:04Z

Description

Upgrade eslint to v9

Related links, issue #, if available: n/a

How has this been tested?

PR build
Made some rule violations locally, saw eslint errors

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

just-boris · 2025-05-14T17:27:10Z

pages/bar-chart/stacked-permutations.page.tsx

@@ -15,7 +15,6 @@ const data1 = [...data, thresholdSeries];
 // Position of the threshold series in a stacked chart must not affect chart's plot.
 const data2 = [data[0], thresholdSeries, data[1], data[2]];

-/* eslint-disable react/jsx-key */


Eslint now prints a warning if a disable directive does nothing. Removed all useless disables

just-boris · 2025-05-14T17:28:09Z

pages/property-filter/custom-forms.tsx

@@ -130,7 +128,9 @@ export function DateForm({ filter, value, onChange }: PropertyFilterOperatorForm

  // Parse value from filter text when it changes.
  useEffect(() => {
-    filter && setState(parseDateTimeFilter(filter.trim()));


@typescript-eslint/no-unused-expressions is enabled now and it fails on this pattern

just-boris · 2025-05-14T17:30:08Z

src/app-layout-toolbar/__tests__/app-layout-toolbar.test.tsx

@@ -8,7 +8,7 @@ import AppLayoutToolbar, { AppLayoutToolbarProps } from '../../../lib/components
 import createWrapper from '../../../lib/components/test-utils/dom';
 import BreadcrumbGroup from '../../../lib/components/breadcrumb-group';

-export function renderComponent(jsx: React.ReactElement) {


jest/no-export rule in action

just-boris · 2025-05-14T17:31:29Z

src/app-layout/classic.tsx

-    const stickyNotificationsHeight = stickyNotifications ? notificationsHeight ?? 0 : 0;
+    const stickyNotificationsHeight = stickyNotifications ? (notificationsHeight ?? 0) : 0;


Prettier dependency got upgraded in this PR: 3.2.5 -> 3.5.3

just-boris · 2025-05-14T17:34:33Z

src/checkbox/__tests__/common-tests.tsx

@@ -1,5 +1,7 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
+
+/* eslint-disable jest/no-export */


This rule fails to detect test helper files. We do not have too many, disabled manually for now

just-boris · 2025-05-14T17:34:54Z

src/flashbar/collapsible-flashbar.tsx

@@ -278,7 +278,6 @@ export default function CollapsibleFlashbar({ items, ...restProps }: FlashbarPro
              >
                {showInnerContent(item) && (
                  <Flash
-                    // eslint-disable-next-line react/forbid-component-props


We do not have this rule enabled, react/forbid-component-props

just-boris · 2025-06-26T21:01:03Z

eslint.config.mjs

+    },
+  },
+  {
+    files: [


Copied this list from .eslintrc.js without changes. Related ticket: AWSUI-21112

just-boris · 2025-06-26T21:33:28Z

build-tools/eslint/__tests__/ban-files.test.js

-      filename: './src/button/index.tsx',
-      options: [ruleHardcodedPath],
-      errors: [{ message: "Disallowed import 'src/index.ts' in favor of having smaller bundle sizes." }],
-    },


Duplicated test. The new version detects and calls this out

just-boris · 2025-06-26T21:34:13Z

.github/workflows/bundle-size/build.js

@@ -1,13 +1,15 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0


Updated eslint captured all JS/TS files in our repo, not just src

just-boris · 2025-06-26T21:35:20Z

pages/app-layout/fill-content-area.page.tsx

@@ -65,6 +65,7 @@ function CornerMarker(props: {
      xmlns="http://www.w3.org/2000/svg"
      viewBox="0 0 10 10"
      style={{ inlineSize: '50px', blockSize: '50px', position: 'absolute', ...props }}
+      focusable="false"


@cloudscape-design/components/no-implicit-svg-focusable rule in action. Now across the whole project

just-boris · 2025-06-26T21:36:14Z

src/__a11y__/a11y-app-layout-toolbar.test.ts

@@ -18,7 +18,7 @@ describe('A11y checks for app layout toolbar', () => {
    .forEach(inputUrl => {
      const url = `#/light/${inputUrl}?${getUrlParams('refresh-toolbar')}`;
      test(
-        url,
+        `${url}`,


Fixing jest/valid-title

just-boris · 2025-06-26T21:41:03Z

src/test-utils/tsconfig.json

@@ -2,6 +2,7 @@
  "compilerOptions": {
    "strict": true,
    "incremental": true,
+    "types": [],


The default value is not an empty array but node_modules/@types/** which loads some unnecessary typings in the scope

Al-Dani · 2025-07-07T08:47:16Z

src/date-range-picker/__tests__/date-range-picker-absolute.test.tsx

@@ -26,6 +26,7 @@ const defaultProps: DateRangePickerProps = {
 const outsideId = 'outside';
 function renderDateRangePicker(props: DateRangePickerProps = defaultProps) {
  const ref = React.createRef<HTMLInputElement>();
+  console.log(props);


nit: small leftover

codecov · 2025-07-07T11:39:26Z

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.61%. Comparing base (c3faf5c) to head (d5e0438).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/file-dropzone/use-files-dragging.ts	75.00%	1 Missing ⚠️
src/mixed-line-bar-chart/internal.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3509      +/-   ##
==========================================
- Coverage   96.62%   96.61%   -0.01%     
==========================================
  Files         813      813              
  Lines       23687    23700      +13     
  Branches     8312     8305       -7     
==========================================
+ Hits        22887    22898      +11     
- Misses        746      795      +49     
+ Partials       54        7      -47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

just-boris force-pushed the upgrade-eslint branch from 01ea018 to f54db28 Compare May 14, 2025 17:38

just-boris commented May 14, 2025

View reviewed changes

just-boris mentioned this pull request Jun 26, 2025

chore: Upgrade prettier #3617

Merged

just-boris force-pushed the upgrade-eslint branch 3 times, most recently from 960ab78 to 965e863 Compare June 26, 2025 20:58

just-boris commented Jun 26, 2025

View reviewed changes

just-boris force-pushed the upgrade-eslint branch from b951731 to 543e499 Compare June 27, 2025 12:44

just-boris deployed to dev-pages June 27, 2025 14:59 — with GitHub Actions View deployment

just-boris marked this pull request as ready for review June 27, 2025 15:16

just-boris requested a review from a team as a code owner June 27, 2025 15:16

just-boris requested review from Al-Dani and removed request for a team June 27, 2025 15:16

Al-Dani previously approved these changes Jul 7, 2025

View reviewed changes

just-boris added 9 commits July 7, 2025 13:03

chore: Upgrade eslint

6cd9651

fix dependency upgrade issues

5b5a23a

more dependency fixes

1bf0df5

fix custom eslint rule tests

dd8887e

fix jest/valid-title issues

6b449bf

fix date-range-picker tests

44ad2fa

undo changes

58dea3c

fix date-range-picker tests

e3ba781

fix issues after rebase

451e5eb

just-boris dismissed Al-Dani’s stale review via 451e5eb July 7, 2025 11:11

just-boris force-pushed the upgrade-eslint branch from 210ecf2 to 451e5eb Compare July 7, 2025 11:11

more rebase conflicts

d5e0438

just-boris deployed to dev-pages July 7, 2025 11:39 — with GitHub Actions View deployment

just-boris enabled auto-merge July 7, 2025 11:45

just-boris requested a review from Al-Dani July 7, 2025 11:48

Al-Dani approved these changes Jul 7, 2025

View reviewed changes

just-boris added this pull request to the merge queue Jul 7, 2025

Merged via the queue into main with commit 37247fb Jul 7, 2025
38 checks passed

just-boris deleted the upgrade-eslint branch July 7, 2025 12:13

abdhalees pushed a commit that referenced this pull request Jul 8, 2025

chore: Upgrade eslint (#3509)

37bc083

just-boris mentioned this pull request Jul 11, 2025

chore: Upgrade eslint cloudscape-design/code-view#88

Merged

pranshuteotia pushed a commit to pranshuteotia/components that referenced this pull request Sep 3, 2025

chore: Upgrade eslint (cloudscape-design#3509)

be4de32

		const stickyNotificationsHeight = stickyNotifications ? notificationsHeight ?? 0 : 0;
		const stickyNotificationsHeight = stickyNotifications ? (notificationsHeight ?? 0) : 0;

		@@ -1,13 +1,15 @@
		// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
		// SPDX-License-Identifier: Apache-2.0

chore: Upgrade eslint #3509

chore: Upgrade eslint #3509

Uh oh!

Conversation

just-boris commented May 14, 2025

Description

How has this been tested?

Correctness

Security

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

just-boris May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

just-boris May 14, 2025 •

edited

Loading

codecov bot commented Jul 7, 2025 •

edited

Loading