Reduce reflection use in generated C# code #2725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
force-pushed
the
jgilles/perf/faster-allocation
branch
2 times, most recently
from
f574d87 to
df4a55d
Compare
1 task
kazimuth
force-pushed
the
jgilles/perf/faster-allocation
branch
from
df4a55d to
8804a70
Compare
kazimuth
force-pushed
the
jgilles/fix-list-equals
branch
from
c27bf8a to
0c741a6
Compare
kazimuth
force-pushed
the
jgilles/perf/faster-allocation
branch
from
8804a70 to
afdc188
Compare
3 tasks
Add important comment Make enums more direct Comments and csharpier Add method to IStructuralReadWrite to get an IReadWrite<Self>. This is technically a breaking change if anyone is manually implementing IStructuralReadWrite. Remove incorrect comment
kazimuth
force-pushed
the
jgilles/perf/faster-allocation
branch
from
d070125 to
74ad4a1
Compare
|
Git mistake. |
rekhoff
approved these changes
May 12, 2025
|
I've tested against Blackholio and Bitcraft, happy with this. |
kazimuth
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
May 15, 2025
## Description of Changes Leverages clockworklabs/SpacetimeDB#2725 to speed up row deserialization. Also updates DLLs for recent upstream fixes. Changes: - Uses much simpler code when deserializing enums, avoiding the use of reflection - Uses manually monomorphized row deserialization methods, which again avoid the use of reflection when constructing row objects ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs clockworklabs/SpacetimeDB#2725 ## Testsuite SpacetimeDB branch name: jgilles/perf/faster-allocation ## Testing *Write instructions for a test that you performed for this PR* - [x] Blackholio - [x] Bitcraft (have done a basic test but no in-depth testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Directly allocates results for some operations and avoids the usage of reflection for enum serialization.
This should hopefully speed up (de)serialization to some extent.
Needs to be paired with an upcoming C# SDK PR to speed these up further.
API and ABI breaking changes
Adds a method to IStructuralReadWrite, which will break anyone who manually implements it. However, nobody should be manually implementing it. I've checked, and Bitcraft doesn't.
Expected complexity level and risk
0
Testing