Comments and csharpier

Author: kazimuth

crates/bindings-csharp/BSATN.Codegen/Type.cs

@@ -529,11 +529,14 @@ public override string ToString() =>
             """
             );
 
+            // Directly allocating the result object here (instead of calling e.g. IStructuralReadWrite.Read<T>, which does the same thing)
+            // avoids generics; we've found that generics often result in reflective code being generated.
+            // Using simple code here hopefully helps IL2CPP and Mono do this faster.
             read = $$"""
-                var ___result = new {{FullName}}();
-                ___result.ReadFields(reader);
-                return ___result;
-            """;
+                    var ___result = new {{FullName}}();
+                    ___result.ReadFields(reader);
+                    return ___result;
+                """;
 
             write = "value.WriteFields(writer);";
 

crates/bindings-csharp/BSATN.Runtime.Tests/Tests.cs

@@ -330,26 +330,38 @@ public void AssertCollisionsLessThan(double fraction)
     }
 
     static void TestRoundTrip<T, BSATN>(Gen<T> gen, BSATN serializer)
-    where BSATN : IReadWrite<T>
+        where BSATN : IReadWrite<T>
     {
-        gen.Sample((value) =>
-        {
-            var stream = new MemoryStream();
-            var writer = new BinaryWriter(stream);
-            serializer.Write(writer, value);
-            stream.Seek(0, SeekOrigin.Begin);
-            var reader = new BinaryReader(stream);
-            var result = serializer.Read(reader);
-            Assert.Equal(value, result);
-        }, iter: 10_000);
+        gen.Sample(
+            (value) =>
+            {
+                var stream = new MemoryStream();
+                var writer = new BinaryWriter(stream);
+                serializer.Write(writer, value);
+                stream.Seek(0, SeekOrigin.Begin);
+                var reader = new BinaryReader(stream);
+                var result = serializer.Read(reader);
+                Assert.Equal(value, result);
+            },
+            iter: 10_000
+        );
     }
 
     [Fact]
     public static void GeneratedProductRoundTrip()
     {
-        TestRoundTrip(GenBasic.Select(value => new BasicDataClass(value)), new BasicDataClass.BSATN());
-        TestRoundTrip(GenBasic.Select(value => new BasicDataRecord(value)), new BasicDataRecord.BSATN());
-        TestRoundTrip(GenBasic.Select(value => new BasicDataStruct(value)), new BasicDataStruct.BSATN());
+        TestRoundTrip(
+            GenBasic.Select(value => new BasicDataClass(value)),
+            new BasicDataClass.BSATN()
+        );
+        TestRoundTrip(
+            GenBasic.Select(value => new BasicDataRecord(value)),
+            new BasicDataRecord.BSATN()
+        );
+        TestRoundTrip(
+            GenBasic.Select(value => new BasicDataStruct(value)),
+            new BasicDataStruct.BSATN()
+        );
     }
 
     [Fact]
@@ -432,8 +444,7 @@ public partial record BasicEnum
             BasicDataClass U,
             BasicDataStruct V,
             BasicDataRecord W
-        )>
-    { }
+        )> { }
 
     static readonly Gen<BasicEnum> GenBasicEnum = Gen.SelectMany<int, BasicEnum>(
         Gen.Int[0, 7],
@@ -595,7 +606,6 @@ public ContainsNestedList(List<BasicEnum[][]> theList)
         .List[0, 2]
         .Select(list => new ContainsNestedList(list));
 
-
     [Fact]
     public static void GeneratedNestedListRoundTrip()
     {
@@ -646,7 +656,6 @@ public override int GetHashCode([DisallowNull] IEnumerable<T> obj)
         }
     }
 
-
     [Fact]
     public static void GeneratedNestedListEqualsWorks()
     {