Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Jazzy. Tests are now passing (on my machine at least). Necessary changes:
test.launch/*.launch
to the installed files; otherwise theJob
object cannot locate the launch files to installupstart
configuration file with newersystemd
configuration fileI'd appreciate someone running the tests on different machines and different ROS distributions to make sure the changes work on those too before we release an updated version.
General testing process:
Make sure the log doesn't show any assertion failures. Assuming there aren't any we should be in good shape.