Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass on ROS 2 #124

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Make tests pass on ROS 2 #124

merged 11 commits into from
Sep 9, 2024

Conversation

civerachb-cpr
Copy link
Contributor

Tested on Jazzy. Tests are now passing (on my machine at least). Necessary changes:

  1. Add test.launch/*.launch to the installed files; otherwise the Job object cannot locate the launch files to install
  2. Replace check for upstart configuration file with newer systemd configuration file

I'd appreciate someone running the tests on different machines and different ROS distributions to make sure the changes work on those too before we release an updated version.

General testing process:

cd /path/to/workspace
rm -rf install/robot_upstart
colcon build --packages-select robot_upstart
colcon test --packages-select robot_upstart
cat log/latest_test/robot_upstart/stdout.log

Make sure the log doesn't show any assertion failures. Assuming there aren't any we should be in good shape.

@civerachb-cpr civerachb-cpr merged commit 67ffc02 into foxy-devel Sep 9, 2024
2 checks passed
@civerachb-cpr civerachb-cpr deleted the test-fix branch September 9, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant