Skip to content

feat(sboms): do not fail on duplicated elements (cyclonedx) #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiparis merged 1 commit into from
Nov 13, 2025
Merged

feat(sboms): do not fail on duplicated elements (cyclonedx) #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions internal/schemavalidators/schemavalidators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,16 @@ func ValidateCycloneDX(data interface{}, version CycloneDXVersion) error {
}
var validationError *jsonschema.ValidationError
if errors.As(err, &validationError) {
if slices.ContainsFunc(validationError.Causes, func(v0 *jsonschema.ValidationError) bool {
return slices.ContainsFunc(v0.Causes, func(v1 *jsonschema.ValidationError) bool {
// workaround: Some scanners like Jfrog Xray might report null `cwes` element ("cwes": null)
if slices.ContainsFunc(validationError.Causes, func(cause *jsonschema.ValidationError) bool {
// Jfrog Xray: Do not fail in case of duplicated components. Policies will take care of validation and deduplication
if cause.KeywordLocation == "/properties/components/uniqueItems" {
return true
}
// Some validation errors are found deeper in the tree
return slices.ContainsFunc(cause.Causes, func(c1 *jsonschema.ValidationError) bool {
// Some scanners like Jfrog Xray might report null `cwes` element ("cwes": null)
// the validator would fail with "expected array, but got null"
return v1.KeywordLocation == "/properties/vulnerabilities/items/$ref/properties/cwes/type"
return c1.KeywordLocation == "/properties/vulnerabilities/items/$ref/properties/cwes/type"
})
}) {
return nil
Expand Down
4 changes: 4 additions & 0 deletions internal/schemavalidators/schemavalidators_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ func TestValidateCycloneDX1_6(t *testing.T) {
name: "1.6 version",
filePath: "./testdata/sbom.cyclonedx-1.6.json",
},
{
name: "1.6 version with duplicated element",
filePath: "./testdata/sbom.cyclonedx-duplicated.json",
},
}

for _, tc := range testCases {
Expand Down
72 changes: 72 additions & 0 deletions internal/schemavalidators/testdata/sbom.cyclonedx-duplicated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
{
"bomFormat": "CycloneDX",
"specVersion": "1.6",
"serialNumber": "urn:uuid:e8c355aa-2142-4084-a8c7-6d42c8610ba2",
"version": 1,
"metadata": {
"timestamp": "2024-01-09T12:00:00Z",
"component": {
"type": "application",
"name": "my application",
"version": "1.0"
}
},
"components": [
{
"name": "TLSv1.2",
"type": "cryptographic-asset",
"bom-ref": "crypto/protocol/[email protected]",
"cryptoProperties": {
"assetType": "protocol",
"protocolProperties": {
"type": "tls",
"version": "1.2",
"cipherSuites": [
{
"name": "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
"algorithms": [
"crypto/algorithm/[email protected]",
"crypto/algorithm/[email protected]",
"crypto/algorithm/[email protected]",
"crypto/algorithm/[email protected]"
],
"identifiers": [ "0xC0", "0x30" ]
}
],
"cryptoRefArray": [
"crypto/certificate/google.com@sha256:1e15e0fbd3ce95bde5945633ae96add551341b11e5bae7bba12e98ad84a5beb4"
]
},
"oid": "1.3.18.0.2.32.104"
}
},
{
"name": "TLSv1.2",
"type": "cryptographic-asset",
"bom-ref": "crypto/protocol/[email protected]",
"cryptoProperties": {
"assetType": "protocol",
"protocolProperties": {
"type": "tls",
"version": "1.2",
"cipherSuites": [
{
"name": "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
"algorithms": [
"crypto/algorithm/[email protected]",
"crypto/algorithm/[email protected]",
"crypto/algorithm/[email protected]",
"crypto/algorithm/[email protected]"
],
"identifiers": [ "0xC0", "0x30" ]
}
],
"cryptoRefArray": [
"crypto/certificate/google.com@sha256:1e15e0fbd3ce95bde5945633ae96add551341b11e5bae7bba12e98ad84a5beb4"
]
},
"oid": "1.3.18.0.2.32.104"
}
}
]
}
Loading