Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error reporting #1908

Merged

Conversation

RunDevelopment
Copy link
Member

This fixes 2 bugs:

  1. The frontend assumes that all inputs have information about their current values. This is not the case. If the logic for deriving this information fails, we don't have it. If the node executor itself has a bug, we don't have this information either. Since error reporting must not fail, I choose to conservatively assume that we might not have values for everything.
  2. get_error_value was implemented incorrectly for ImageInput. The value could be None, but this was not accounted for. This is the 'NoneType' object has no attribute 'shape' we see here.

In addition to this, I also added a try around collection error data. It's better to have less data than for the collection itself to error and hide the original error.

Error reporting should now be a lot more robust.

@joeyballentine joeyballentine merged commit 286cb1c into chaiNNer-org:main Jul 3, 2023
@RunDevelopment RunDevelopment deleted the fixed-error-reporting branch July 3, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants