Fixed error reporting (#1908)

* Fixed error reporting * Error reporting should never fail
chaiNNer-org · Jul 3, 2023 · 286cb1c · 286cb1c
1 parent b316559
commit 286cb1c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/backend/src/nodes/properties/inputs/numpy_inputs.py b/backend/src/nodes/properties/inputs/numpy_inputs.py
@@ -79,7 +79,10 @@ def enforce(self, value):
 
         return value
 
-    def get_error_value(self, value: np.ndarray | Color) -> ErrorValue:
+    def get_error_value(self, value: np.ndarray | Color | None) -> ErrorValue:
+        if value is None:
+            return super().get_error_value(value)
+
         def get_channels(channel: int) -> str:
             if channel == 1:
                 return "Grayscale"

diff --git a/backend/src/process.py b/backend/src/process.py
@@ -71,8 +71,14 @@ def run_node(node: NodeData, inputs: Iterable[object], node_id: NodeId) -> Outpu
         # collect information to provide good error messages
         input_dict: InputsDict = {}
         for index, node_input in enumerate(node.inputs):
-            input_value = enforced_inputs[index]
-            input_dict[node_input.id] = node_input.get_error_value(input_value)
+            try:
+                input_value = enforced_inputs[index]
+                input_dict[node_input.id] = node_input.get_error_value(input_value)
+            except Exception as inner_e:
+                logger.error(
+                    f"Error getting error value for input {node_input.label} (id {node_input.id})",
+                    inner_e,
+                )
 
         raise NodeExecutionError(node_id, node, str(e), input_dict) from e
 

diff --git a/src/common/Backend.ts b/src/common/Backend.ts
@@ -39,7 +39,7 @@ export type BackendErrorValue =
 export interface BackendExceptionSource {
     nodeId: string;
     schemaId: SchemaId;
-    inputs: Record<InputId, BackendErrorValue>;
+    inputs: Partial<Record<InputId, BackendErrorValue>>;
 }
 export interface BackendExceptionResponse {
     type: 'error';

diff --git a/src/common/formatExecutionErrorMessage.ts b/src/common/formatExecutionErrorMessage.ts
@@ -21,7 +21,9 @@ export const formatExecutionErrorMessage = (
         const inputValue = source.inputs[i.id];
 
         let valueStr: string;
-        if (inputValue.type === 'formatted') {
+        if (inputValue === undefined) {
+            valueStr = '*unknown*';
+        } else if (inputValue.type === 'formatted') {
             valueStr = inputValue.formatString;
         } else if (inputValue.type === 'unknown') {
             valueStr = `Value of type '${inputValue.typeModule}.${inputValue.typeName}'`;