Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21106] Binding correct AuditLogWriter implementation for a Distributed Program incase of SYSTEM SERVICE. #15791

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[CDAP-21106] Binding correct AuditLogWriter implementation for a Distributed Program incase of SYSTEM SERVICE. #15791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cdap-app-fabric/src/main/java/io/cdap/cdap/app/guice/DistributedProgramContainerModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@
import io.cdap.cdap.metadata.PreferencesFetcher;
import io.cdap.cdap.metadata.RemotePreferencesFetcherInternal;
import io.cdap.cdap.metrics.guice.MetricsClientRuntimeModule;
import io.cdap.cdap.proto.ProgramType;
import io.cdap.cdap.proto.id.NamespaceId;
import io.cdap.cdap.proto.id.ProgramId;
import io.cdap.cdap.proto.id.ProgramRunId;
import io.cdap.cdap.runtime.spi.RuntimeMonitorType;
Expand Down Expand Up @@ -159,7 +161,7 @@ private List<Module> getCoreModules() {

List<Module> modules = new ArrayList<>();

modules.add(new NoOpAuditLogModule());
modules.add(getAuditLogModules());
modules.add(new ConfigModule(cConf, hConf));
modules.add(new IOModule());
modules.add(new DFSLocationModule());
Expand Down Expand Up @@ -303,6 +305,18 @@ private static String generateClientId(ProgramRunId programRunId, String instanc
return String.format("%s.%s.%s", programRunId.getParent(), programRunId.getRun(), instanceId);
}

/**
* Return distributed module only if the program is of SERVICE in SYSTEM namespace.
*/
private Module getAuditLogModules() {
if (programRunId.getNamespaceId().equals(NamespaceId.SYSTEM)
&& programRunId.getType().equals(ProgramType.SERVICE)) {
return new AuditLogWriterModule(cConf).getDistributedModules();
}

return new NoOpAuditLogModule();
}

/**
* A Guice module to provide {@link ProgramStateWriter} binding. In normal same cluster / remote
* cluster execution, it just publishes program states to TMS based on the discovery service. For
Expand Down
Loading