[CDAP-21106] Binding correct AuditLogWriter implementation for a Distributed Program incase of SYSTEM SERVICE. #15791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Pipeline StudioService
( which runsConnectionHandler
) is instantiated using AbstractProgramTwillRunnable.This is also used by DataPipelineApp, which is used to run pipelines.
SO a
NoOpAuditLogModule
was binded to this. (DistributedProgramContainerModule
).Because of which the Audit logs were going to NoOp.
Now:
Adding the correct implementation for SYSTEM SERVICES which can derived from
programRunId
. For rest, continue to use NoOp.Testing :