Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21106] Binding correct AuditLogWriter implementation for a Distributed Program incase of SYSTEM SERVICE. #15791

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sahusanket
Copy link
Contributor

@sahusanket sahusanket commented Jan 3, 2025

The Pipeline StudioService ( which runs ConnectionHandler) is instantiated using AbstractProgramTwillRunnable.

This is also used by DataPipelineApp, which is used to run pipelines.
SO a NoOpAuditLogModule was binded to this. (DistributedProgramContainerModule).

Because of which the Audit logs were going to NoOp.

Now:

Adding the correct implementation for SYSTEM SERVICES which can derived from programRunId. For rest, continue to use NoOp.

Testing :

@sahusanket sahusanket added the build Triggers github actions build label Jan 3, 2025
@sahusanket sahusanket self-assigned this Jan 3, 2025
@sahusanket sahusanket force-pushed the CDAP-21106_fix_connectionHandler_logs branch from 78fc531 to cec170f Compare January 7, 2025 13:30
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
52.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sahusanket sahusanket requested a review from tivv January 7, 2025 15:28
@sahusanket sahusanket merged commit 965b183 into develop Jan 8, 2025
11 of 12 checks passed
@sahusanket sahusanket deleted the CDAP-21106_fix_connectionHandler_logs branch January 8, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers github actions build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants