docs: fix stale platforms/ios paths after Apple consolidation (#968) + remaining-work plan#969
Open
thymikee wants to merge 1 commit into
Open
docs: fix stale platforms/ios paths after Apple consolidation (#968) + remaining-work plan#969thymikee wants to merge 1 commit into
thymikee wants to merge 1 commit into
Conversation
Post-#968 follow-up: the OS-agnostic Apple runner engine moved from src/platforms/ios/ to src/platforms/apple/core/, but several docs/config still pointed at the old locations, misleading agents that grep those paths. - AGENTS.md: repoint the runner-seam map, the Apple-family sync rule, the record/trace seam, the search-roots hint, and the platform-backends list at src/platforms/apple/core/...; rename "iOS Runner Seams" -> "Apple Runner Seams". - .fallowrc.json: drop the two stale ignoreExports entries for the removed src/platforms/ios/apps.ts and src/platforms/ios/index.ts (the live src/platforms/apple/core/apps.ts entry already covers those test-only exports). - ios-runner/{README,RUNNER_PROTOCOL}.md: point the TypeScript-client links at src/platforms/apple/core/runner/runner-client.ts. Docs/config only; no behavior change. fallow audit + build/lint stay green, and a live iOS simulator replay suite (6/6) confirms the consolidated runner works.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Member
Author
|
Review pass for head ddd6a1f found no actionable blockers. Checked against ADR-0009 and the Phase 3 platform-plugin plan: the PR only updates stale docs/config paths after #968, keeps the remaining Apple work explicitly sequenced, and does not claim the public Platform collapse or deferred Apple leaf work is done. The replacement runner/device/app paths exist under src/platforms/apple/core, and the removed fallow ignores target src/platforms/ios files that no longer exist on main. All 21 reported checks are green, and the PR body includes live iOS simulator replay evidence for the relocated runner path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-#968 (Apple platform consolidation) follow-up: doc/config path fixes, live runner validation, and the decomposed plan for the remaining Phase 3 work.
1. Stale path fixes (the code change here)
#968 moved the OS-agnostic Apple runner engine from
src/platforms/ios/tosrc/platforms/apple/core/, but several docs/config still pointed at the old locations (actively misleading to agents grepping those paths):record/traceseam, the search-roots hint, and the platform-backends list atsrc/platforms/apple/core/...; renamed "iOS Runner Seams" → "Apple Runner Seams".ignoreExportsentries for the removedsrc/platforms/ios/{apps,index}.ts(the livesrc/platforms/apple/core/apps.tsentry already covers those test-only exports).src/platforms/apple/core/runner/runner-client.ts.Docs/config only; no behavior change.
fallow audit,tsc,oxlint --deny-warnings, andrslib buildstay green.2. Live runner validation
Ran the full iOS simulator replay suite on a booted iPhone 17 Pro (building the runner fresh): 6/6 passed in 160s —
01-settings,02-deep-navigation,03-scroll-discovery,04-text-input-keyboard,05-app-lifecycle,06-swipe-gestures. Confirms the consolidated Apple runner works live across tap/scroll/type/swipe/lifecycle. (This is the live smoke replay the plan now relies on after the request-count CI gate was removed.)3. My #968 review follow-ups — already resolved in the merge
Items 3–5 from the review are addressed in the merged #968: the existing iOS/tvOS/macOS
disallowedSDK lists do not containxros/xrsimulator(only the new visionOS row does); thedevice.tsvisionOS comment is accurate; andapple/coreno longer imports backward throughios/shims (the shims are deleted, imports point at siblings).Remaining Phase 3 work (plan — needs issues filed)
The remaining work from
plans/phase3-platform-plugin-progress.mddecomposes into the units below. I have full agent-ready bodies for each but could not auto-file them as GitHub issues (blocked by the external-write guard — needs your OK). Once filed,plans/phase3-platform-plugin-progress.mdcan be removed (its content lives in the issues +perfect-shape.md§5–7 + ADR-0009).Sequencing (→ = blocked by):
supports()/unsupportedHint()Apple closures ontoplugin.capability.supportsByDefault(parity-gated)providers/recording/appLog/perf(4-way fan-out, each parity-gated)interactions.tsunderplatforms/appleAppleOScapability tablesPlatformcollapseios/macos→apple(~59 macOS + 47isApplePlatformsites)platforms/ios/__tests__(+ splitindex.test.ts, moverecording-scripts.test.ts)ios-runner→apple-runner+runIosRunnerCommand/createIosRunnerCachePrewarmOnColdBootDiscipline (perfect-shape §7): every derived table/closure is pinned by a table-/closure-equivalence parity test across
src/__tests__/test-utils/device-fixtures.tsbefore any hand site is deleted; do not flatten the leaves (two-finger XCTest synthesis, tvOS focus-only, AppKit macOS helper).