ostree-ext: update ostree rust bindings and use new feature #1401
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request updates the ostree rust bindings and enables a new feature, v2025_3. It also downgrades the windows-sys dependency to version 0.52.0. The changes include updates to the Cargo.lock and ostree-ext/Cargo.toml files. It's important to verify the compatibility and functionality of the updated dependencies and the new feature.
There was a problem hiding this comment.
LGTM but this is going to fail until we have the new ostree upstream release shipped everywhere, which is going to be really painful 😢
So tempting again to just vendor ostree, or at least vendor the sysroot parts...
With some nontrivial work what we could do is detect at build time (via a build.rs script) whether a new enough ostree is available, and then only access the updated APIs via a #[cfg()].
We need to ship anywhere either way... I will go do that. |
jmarrero
force-pushed
the
update-ostree-ext
branch
from
8d9c2b5 to
4708643
Compare
|
|
jmarrero
force-pushed
the
update-ostree-ext
branch
from
4708643 to
5c44b24
Compare
|
I'm going to take a quick run at making this a build time conditional |
Add machinery to do dynamic build time detection of ostree, and only enable use of the feature if we have a new enough version. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
update-ostree-ext
branch
from
5c44b24 to
d74531c
Compare
|
OK well, I made it work...except that it only works because we messed up the |
This allows us to enable soft-reboot