Repository navigation
fix(chain): implement request builder exts for any checkpoint data - #2438
Closed
bhuvan-somisetty wants to merge 2 commits into
Closed
bhuvan-somisetty wants to merge 2 commits into
bhuvan-somisetty wants to merge 2 commits into
Conversation
`SyncRequestBuilderExt` and `FullScanRequestBuilderExt` were only implemented for builders whose checkpoint data is `BlockHash`, the default `D`. A builder for a `CheckPoint<Header>` (or any other `D`) could not call `revealed_spks_from_indexer`, `unused_spks_from_indexer` or `spks_from_indexer`, even though the builders themselves and `LocalChain` are generic over `D`. The impls never touch the checkpoint data, so make them generic over `D`.
`cargo update -p yoke-derive --precise "0.8.2"` now fails because the locked dependency graph requires `yoke-derive ^0.8.4`, which breaks the "Pin dependencies for MSRV" step. The MSRV job only builds the libraries since bitcoindevkit#2421 and passes without this pin, so drop it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2438 +/- ##
==========================================
+ Coverage 80.66% 81.18% +0.52%
==========================================
Files 31 31
Lines 6236 6236
Branches 293 294 +1
==========================================
+ Hits 5030 5063 +33
+ Misses 1136 1103 -33
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 of 4 tasks
3 of 4 tasks
Member
|
Thanks for this. It's carried on in #2439, which also makes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SyncRequestBuilderExtandFullScanRequestBuilderExtwere only implemented for builders with the default checkpoint dataD = BlockHash, sorevealed_spks_from_indexer,unused_spks_from_indexerandspks_from_indexercould not be called when building a request for aCheckPoint<Header>(or any otherD). The impls never use the checkpoint data, so they are now generic overD.Fixes #2437
Notes to the reviewers
Same kind of change as #2417. Callers using the default
D = BlockHashare unaffected.The added test fails to compile without the fix (
error[E0599]: no method named revealed_spks_from_indexer found for struct SyncRequestBuilder<I, D>).The MSRV job currently fails on every PR at "Pin dependencies for MSRV" (
yoke-derive = "^0.8.4"can't be pinned to 0.8.2), unrelated to this change. The second commit drops that pin so CI is green; it is the same change as in #2435 and can be dropped from here if that merges first.Changelog notice
Fixed
bdk_chain:SyncRequestBuilderExtandFullScanRequestBuilderExtare implemented for request builders with any checkpoint data typeDfix(chain): implement request builder exts for any checkpoint data #2438Checklists
All Submissions:
Bugfixes: