MNT: Bump hed-validator from 3.5.0 to 3.7.1 #1464
Conversation
|
Looks like new hed-validator uses class properties which aren't supported by our old nextjs/webpack/babel setup. babel es2022 presets include the plugin to handle these. |
|
@rwblair Do we need to do anything about this or can you do this? We would like to get this pushed through as it significantly improves the error reporting on the HED side. |
|
@VisLab Ross is out for a couple weeks. If your group knows how to fix this and can get tests passing, then I'm happy to merge. |
|
I went ahead and bypassed the issue by releasing version 3.7.1 of |
|
@effigies I don't have commit rights to this repository, so I need the
|
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 90 90
Lines 3650 3650
Branches 1109 1109
=======================================
Hits 3067 3067
Misses 489 489
Partials 94 94 Continue to review full report at Codecov.
|
|
githubPagesTest passes. Note that we do see an error: I will open a separate PR to avoid infecting this one. |
effigies
changed the title
|
@happy5214 @VisLab Do you need a validator release, or are you able to work with it as a development version? |
|
Thanks for getting this merged. We would really like a validator release.
Some of the changes involve eliminating the multiple reporting of the same
issue, which really bogs down the validation process.
…On Tue, Jun 7, 2022 at 2:18 PM Chris Markiewicz ***@***.***> wrote:
@happy5214 <https://github.com/happy5214> @VisLab
<https://github.com/VisLab> Do you need a validator release, or are you
able to work with it as a development version?
—
Reply to this email directly, view it on GitHub
<https://github.com/bids-standard/bids-validator/pull/1464#issuecomment-1149068577>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCJOWXA5RMCE3ZGSL6KELVN6N6XANCNFSM5X2BC36A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Looks like I don't have permissions to upload to npm. I'll see if I can get them, but with people on vacation it might be slow... |
|
Understood....your help is much appreciated.
…On Tue, Jun 7, 2022 at 3:41 PM Chris Markiewicz ***@***.***> wrote:
Looks like I don't have permissions to upload to npm. I'll see if I can
get them, but with people on vacation it might be slow...
—
Reply to this email directly, view it on GitHub
<https://github.com/bids-standard/bids-validator/pull/1464#issuecomment-1149147026>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCJOQ5JBQE234DJFZ2MULVN6XZNANCNFSM5X2BC36A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Well, managed to tag and push to git with lerna, but attempting to publish to npm is failing. Might be jprichardson/node-fs-extra#657 but don't have time to track down right now. Tried on two separate computers with different node installations. In case someone else has ideas... |
|
Not sure what was up with lerna. was able to publish just using npm by itself: @VisLab Let us know if the published package works as expected for you. |
|
Thanks @rwblair! Please stop working and have a beer. |
|
… On Wed, Jun 8, 2022 at 1:13 PM Chris Markiewicz ***@***.***> wrote:
Thanks @rwblair <https://github.com/rwblair>! Please stop working and
have a beer.
—
Reply to this email directly, view it on GitHub
<https://github.com/bids-standard/bids-validator/pull/1464#issuecomment-1150238138>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCJOR5FQI6YAEUTS6NCOTVODPF7ANCNFSM5X2BC36A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I should be able to take a look at this in a couple hours. Will let you
know what I see.
…On Wed, Jun 8, 2022, 2:50 PM Chris Markiewicz ***@***.***> wrote:
Well, managed to tag and push to git with lerna, but attempting to publish
to npm is failing.
lerna info publish Publishing packages to npm...
lerna info Verifying npm credentials
lerna http fetch GET 200 https://registry.npmjs.org/-/npm/v1/user 431ms
lerna http fetch GET 200 https://registry.npmjs.org/-/org/cjmarkie/package?format=cli 324ms (cache updated)
lerna info Checking two-factor auth mode
lerna http fetch GET 200 https://registry.npmjs.org/-/npm/v1/user 263ms
lerna ERR! Error: Source and destination must not be the same.
lerna ERR! at /home/chris/.npm/_npx/d5cad42883f80c04/node_modules/fs-extra/lib/util/stat.js:39:17
lerna ERR! lerna Source and destination must not be the same.
Might be jprichardson/node-fs-extra#657
<jprichardson/node-fs-extra#657> but don't have
time to track down right now. Tried on two separate computers with
different node installations. In case someone else has ideas...
—
Reply to this email directly, view it on GitHub
<https://github.com/bids-standard/bids-validator/pull/1464#issuecomment-1149942414>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADR4QJYB377V2GEFNFRPPDTVOCQJHANCNFSM5X2BC36A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fixes #1457