MNT: Upgrade eslint to 8.17

[effigies]

Mostly in response to an error (albeit non-breaking) seen while reviewing #1464. I assume there isn't a strong reason to hold onto 5.2.

[codecov]

Codecov Report

Merging #1466 (aa4aaea) into master (f3b443b) will not change coverage.
The diff coverage is n/a.

❗ Current head aa4aaea differs from pull request most recent head 7be4f9a. Consider uploading reports for the commit 7be4f9a to get more accurate results

@@           Coverage Diff           @@
##           master    #1466   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files          90       90           
  Lines        3650     3650           
  Branches     1109     1109           
=======================================
  Hits         3067     3067           
  Misses        489      489           
  Partials       94       94           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b443b...7be4f9a. Read the comment docs.

[sappelhoff]

tests pass, merging, thanks!