Make SystemSet
marker traits mutually exclusive
#8032
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix an issue discussed in #7882. The problem comes down to the fact that
BaseSystemSet
andFreeSystemSet
can both be implemented for the same type, which opens the door for misuse and results in actively harmful error messages.Solution
Use an associated type to determine whether a system set is base or not. Add blanket implementations to the marker traits based on the value of the associated type. Users are disallowed from manually implementing either marker trait due to blanket implementations, which ensures that the two traits are disjoint.
Migration Guide
The marker traits
BaseSystemSet
andFreeSystemSet
can no longer be implemented manually. Instead, implementKindedSystemSet
: