Show warning when no camera is used #6978
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show a warning if meshes get rendered without a camera. Fix: bevyengine#1432
|
Hmm yeah I don't love that this is spinning and constantly checking and warning. Is there an initialization step where we could check this? |
|
Not a fan of adding a system just for that, and I'm not convinced there isn't a use case for having meshes without a camera |
mockersf
added
A-Rendering
|
@alice-i-cecile I will take a look and see if I can find something. |
|
Yep, if you can't find a good way to do this without a system we should just close the issue. |
|
I agree that there might be use cases for having meshes without cameras, and I'm also not a fan of a system spinning to do this check each frame. Feel free to open a new PR if you find something that works around these issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Show a warning if meshes get rendered without a camera.
Fixes #1432
Solution
Add a system to the extract render stage that queries for all cameras and all meshes. If only meshes and no camera was found, a warning gets emitted.
What I don't like about this solution, is that the console gets spammed by the warning. Please let me know what you think.
Changelog
Print a warning when trying to render meshes without a camera.