[Merged by Bors] - Fix crash in headless mode #4476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
|
Is the headless_defaults file referred to somewhere else or was it missed from this PR? |
|
it triggers running the example in CI |
mockersf
approved these changes
Apr 14, 2022
superdump
approved these changes
Apr 14, 2022
| ) { | ||
| let render_device = match render_device { | ||
| Some(render_device) => render_device, | ||
| None => return, |
There was a problem hiding this comment.
I wish there were a nicer syntax for doing this, like a ? operator that just returns if none else unwraps it. But I’m not aware of any.
There was a problem hiding this comment.
Let else will help with this slightly.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2022
# Objective Fixes #4440. ## Solution Check if `RenderDevice` exists and add CI validation.
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective Fixes bevyengine#4440. ## Solution Check if `RenderDevice` exists and add CI validation.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#4440. ## Solution Check if `RenderDevice` exists and add CI validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #4440.
Solution
Check if
RenderDeviceexists and add CI validation.