Skip to content

[Merged by Bors] - CI: use lavapipe instead of swiftshader when running examples #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - CI: use lavapipe instead of swiftshader when running examples #3358

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 17, 2021 •
edited
Loading

Objective

Solution

  • thanks to the nice folks at wgpu, I was able to switch from swift shader to lavapipe which is faster
  • I also reduced the runtime for some of the examples
  • I enabled the trace_chrome feature on the examples, and stored the results as an artefact. it can be useful to debug
  • runtime is back to around 10 minutes

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Dec 17, 2021
@cart
Copy link
Member

cart commented Dec 17, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 17, 2021
@mockersf
CI: use lavapipe instead of swiftshader when running examples (#3358)
2217afb 
# Objective

- fixes #3344
- have example run faster

## Solution

- thanks to the nice folks at wgpu, I was able to switch from swift shader to lavapipe which is faster
- I also reduced the runtime for some of the examples
- I enabled the trace_chrome feature on the examples, and stored the results as an artefact. it can be useful to debug
- runtime is back to around 10 minutes


Co-authored-by: François <[email protected]>
DJMcNab
DJMcNab approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really able to comment much.

It doesn't look wrong though?

@bors
Copy link
Contributor

bors bot commented Dec 17, 2021

Build failed:

@mockersf
Copy link
Member Author

timeout from GitHub Actions

@mockersf
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Dec 17, 2021
@mockersf
CI: use lavapipe instead of swiftshader when running examples (#3358)
e677755 
# Objective

- fixes #3344
- have example run faster

## Solution

- thanks to the nice folks at wgpu, I was able to switch from swift shader to lavapipe which is faster
- I also reduced the runtime for some of the examples
- I enabled the trace_chrome feature on the examples, and stored the results as an artefact. it can be useful to debug
- runtime is back to around 10 minutes


Co-authored-by: François <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 18, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title CI: use lavapipe instead of swiftshader when running examples [Merged by Bors] - CI: use lavapipe instead of swiftshader when running examples Dec 18, 2021
@bors bors bot closed this Dec 18, 2021
@alice-i-cecile alice-i-cecile mentioned this pull request Dec 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DJMcNab DJMcNab DJMcNab approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

running examples in CI got a lot slower since using the new renderer
3 participants
@mockersf @cart @DJMcNab