-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[pbr] Create a DirectionalLightBundle #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bors try |
tryBuild failed: |
Normally I would merge this because it is relatively uncontroversial and provides useful functionality, but we are planning on overhauling bevy_render prior to 0.6 and I'd prefer to hold off on merging more changes to the current renderer. I think we should leave this open. If the renderer overhaul lands prior to 0.6 (which we're working very hard to do), we can close this out. If not, we can merge this to provide some extra value in 0.6. |
there is now a bevy/crates/bevy_pbr/src/bundle.rs Lines 70 to 78 in add1818
|
Objective
Solution
DirectionalLightBundle
inbevy_pbr
withTransform
andGlobalTransform
componentsDirectionalLight
component to thePbrPlugin
's registered types3d_scene
example by replacing thePointLightBundle
with theDirectionalLightBundle
**I tried to keep the appearance of the lighting pretty close to the original scene, so the only real difference should be that the new light doesn't have any fall-off. But I could create a new example instead if that would be preferred.