Generic hierarchy propagate #22043
Open
Generic hierarchy propagate #22043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molikto
commented
Dec 6, 2025
| nodes: &NodeQuery<'_, '_, T>, | ||
| ) { | ||
| #[cfg(feature = "std")] | ||
| //let _span = bevy_log::info_span!("input propagation worker").entered(); |
Contributor
Author
There was a problem hiding this comment.
this is just commented out because bevy_log isn't a dependency of bevy_ecs. Not sure if it's necessary to have it. bevy_log::info_span is only called once in entire codebase.
molikto
force-pushed
the
generic-hierachy-2
branch
2 times, most recently
from
6d8860b to
fa31466
Compare
molikto
force-pushed
the
generic-hierachy-2
branch
from
9951aae to
b1084ec
Compare
fix ci more lint more lint fmt fix lint unused mark fix lint fix lint fix again fix compile again
molikto
force-pushed
the
generic-hierachy-2
branch
from
b1084ec to
cb43707
Compare
molikto
commented
Dec 7, 2025
| hierarchy_propagate_simple::<Transform>, | ||
| hierarchy_propagate_complex::<Transform>, | ||
| ) | ||
| .chain(), |
Contributor
Author
There was a problem hiding this comment.
is it possible to write fn hierarchy_down_propagate_chain(): ? { } I don't know that type should this be. I think only this should be pub, the systems should be private
molikto
commented
Dec 7, 2025
| /// Propagates data down the hierarchy from parent to children (like transforms, visibility). | ||
| pub trait DownPropagate { | ||
| /// The input component type that contains the local data to be propagated. | ||
| type Input: Component; |
Contributor
Author
There was a problem hiding this comment.
is it possible to have Input: Bundle so we have multiple input components? I don't think so, does this means we need to have DownPropagate2 etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
DownPropagate. Can be reused in other places.DownPropagateAll changes are very mechanical and I tried to not do any refactors that changes any logic. Easier to review by individual commits.
Solution
Testing