Skip to content

Move asset processing tests to their own file. #21567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Move asset processing tests to their own file. #21567

merged 1 commit into from
Oct 21, 2025
+776 −812

Conversation

andriyDev
Copy link
Contributor

Objective

Solution

  • Move all the asset processor tests into their own file.

Testing

  • Ran the tests in single threaded and multi threaded mode.

@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change C-Testing A change that impacts how we test Bevy or how users test their apps S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 16, 2025
@andriyDev andriyDev force-pushed the split-processor-tests branch from 35147d3 to 342d2fa Compare October 16, 2025 22:20
@andriyDev andriyDev requested a review from janis-bhm October 16, 2025 22:24
alice-i-cecile
alice-i-cecile requested changes Oct 17, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to move this out into a dedicated test file can we use the standard bevy_assets/tests folder and make these integration tests?

Failing that, can we create an asset_processing module and move this + the associated code into it?

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 17, 2025
@andriyDev andriyDev force-pushed the split-processor-tests branch from 342d2fa to ddba4f6 Compare October 21, 2025 15:47
@andriyDev andriyDev added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Oct 21, 2025
@andriyDev
Copy link
Contributor Author

We can't make this an integration test since it requires the multi_threading feature. Without it, the tests just block indefinitely.

We already have the mod processor. I opted not to use it initially since the tests use a bunch of "crate-level" features, not just stuff in the mod processor. But it's fine either way.

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 21, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 21, 2025
Merged via the queue into bevyengine:main with commit 78d940c Oct 21, 2025
40 checks passed
@andriyDev andriyDev deleted the split-processor-tests branch October 21, 2025 19:03
mate-h pushed a commit to mate-h/bevy that referenced this pull request Oct 22, 2025
@andriyDev @mate-h
Move asset processing tests to their own file. (bevyengine#21567)
f9602e8 
# Objective

- Address [this
comment](bevyengine#21566 (comment)).

## Solution

- Move all the asset processor tests into their own file.

## Testing

- Ran the tests in single threaded and multi threaded mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@janis-bhm janis-bhm Awaiting requested review from janis-bhm

+1 more reviewer

@kristoff3r kristoff3r kristoff3r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andriyDev @kristoff3r @alice-i-cecile