Text strikethrough #21555
Merged
Text strikethrough #21555
+378
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TextLayoutInfo`.
Added example `strikeout`. Added draft release note.
…t valuesa after scalefactor changes and section updates.
ickshonpe
added
C-Feature
Merged
alice-i-cecile
added
the
M-Release-Note
alice-i-cecile
approved these changes
Oct 15, 2025
|
Would it be possible to add the ability to change the size and color of the strikeout independent of the text? |
Yep it's really trivial even, just needs another component I left that and underline to followups to keep this PR focused on the basic implementation. |
it-me-joda
approved these changes
Oct 21, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
|
@ickshonpe I did a bit of poking and I agree that "strikethrough" is more common. Can you rename that quick then I'll merge this? |
alice-i-cecile
added
S-Waiting-on-Author
Yep, done. I wasn't sure about the naming either, but "strikeout" is what cosmic text uses internally. |
|
A quick Ctrl-F on GitHub showed ~12 occurrances of "strikeout" left, including in the release note file name. |
alice-i-cecile
added
S-Ready-For-Final-Review
|
Thanks @copygirl @it-me-joda <3 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
# Objective Text Underline ## Solution New `Underline` marker component, add to text entities to draw an underline. This PR is based on #21555, that should probably be reviewed and merged first.
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
# Objective Add minimal strikethrough support for text. ## Solution * Insert the new `Strikethrough` component on any `Text`, `Text2d`, or `TextSpan` entity and its text will be drawn with strikethrough. * The strikethrough geometry is stored in `TextLayoutInfo` in the vec with the section bounding rects. * Rendering is trivial, identical to drawing text background colours except it's a narrower rect drawn in front instead of behind. * Text shadows also have strikethrough if the text does. # This implementation can easily be expanded to support underline, I've already made a follow up PR that does this here: bevyengine#21559. ## Testing ``` cargo run --example strikethrough ``` ## Showcase <img width="1422" height="924" alt="strikeout" src="https://github.com/user-attachments/assets/c8ea2578-e40c-4c46-ae0d-df9e3f261f3a" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add minimal strikethrough support for text.
Solution
Strikethroughcomponent on anyText,Text2d, orTextSpanentity and its text will be drawn with strikethrough.TextLayoutInfoin the vec with the section bounding rects.This implementation can easily be expanded to support underline, I've already made a follow up PR that does this here: #21559.
Testing
Showcase