Skip to content

spec_v2: Auto Exposure #20125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

spec_v2: Auto Exposure #20125

wants to merge 13 commits into from
+206 −149

Conversation

ecoskey
Copy link
Contributor

@ecoskey ecoskey commented Jul 14, 2025

Objective

#17373
#19969

  • Migrate auto_exposure to spec_v2

Solution

  • Did the things

Testing

  • ran auto_exposure

@ecoskey ecoskey mentioned this pull request Jul 14, 2025
Open
43 tasks
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change X-Contentious There are nontrivial implications that should be thought through S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 14, 2025
@andriyDev
Copy link
Contributor

@ecoskey, #20002 changed auto exposure to use systems instead of FromWorld. Can you rebase this PR on that?

P.S., if you're doing more of these migrations, could you make sure you're using RenderStartup instead of FromWorld + initializing in finish?

@andriyDev andriyDev added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Contentious There are nontrivial implications that should be thought through
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecoskey @andriyDev @alice-i-cecile