-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Replace the load_folder API by load_batch #19760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shishanyue
wants to merge
18
commits into
bevyengine:main
Choose a base branch
from
shishanyue:load_folder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+144
−133
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2bbf690
add filter for load_folder
shishanyue 7e51fc0
maybe ok?
shishanyue c29cbcb
fix CI
shishanyue 3808ea9
add LoadBatch to LoadedFolder
shishanyue b09c199
filter
shishanyue 4853f00
a
shishanyue b3e1fe7
fix
shishanyue 3fb17ca
use alloc
shishanyue 79e55f1
ci
shishanyue 50939d2
ci
shishanyue b0e0c2f
ci
shishanyue cc82f14
Remove load_folderAPI
shishanyue 172b4cb
fix asset_loading.rs
shishanyue 5c1320d
pr
shishanyue 011f8ce
have a problem
shishanyue d4cf944
extra_source
shishanyue 484d5c8
fix
shishanyue 5b6ac36
ci
shishanyue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| use alloc::vec::Vec; | ||
|
|
||
| use crate::{Asset, AssetPath, UntypedHandle}; | ||
| use bevy_reflect::TypePath; | ||
|
|
||
| pub struct LoadBatchRequest { | ||
| pub requests: Vec<AssetPath<'static>>, | ||
| } | ||
|
|
||
| impl LoadBatchRequest { | ||
| pub fn new<T>(requests: Vec<T>) -> Self | ||
| where | ||
| T: Into<AssetPath<'static>>, | ||
| { | ||
| Self { | ||
| requests: requests.into_iter().map(Into::into).collect(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// A "loaded batch" containing handles for all assets stored in a given [`AssetPath`]. | ||
| /// | ||
| /// This is produced by [`AssetServer::load_batch`](crate::prelude::AssetServer::load_batch). | ||
| /// | ||
| /// [`AssetPath`]: crate::AssetPath | ||
| #[derive(Asset, TypePath)] | ||
| pub struct LoadedBatch { | ||
| /// The handles of all assets stored in the batch. | ||
| #[dependency] | ||
| pub handles: Vec<UntypedHandle>, | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, but nicer (allows more than just
vec![foo, bar]):