Add ComponentId-taking functions to Entity{Ref,Mut}Except to mirror FilteredEntity{Ref,Mut} #17800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anlumo
force-pushed
the
entityrefexcept-componentid
branch
from
f49bfe3 to
b7a9d9c
Compare
…ilteredEntity{Ref,Mut}.
anlumo
force-pushed
the
entityrefexcept-componentid
branch
from
b7a9d9c to
4d331dd
Compare
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Feb 11, 2025
chescock
reviewed
Feb 12, 2025
| /// Unlike [`EntityRefExcept::get`], this returns a raw pointer to the component, | ||
| /// which is only valid while the [`EntityRefExcept`] is alive. | ||
| #[inline] | ||
| pub fn get_by_id(&self, component_id: ComponentId) -> Option<Ptr<'w>> { |
There was a problem hiding this comment.
I think this could be generalized using DynamicComponentFetch to match the other get_by_id() methods. But that should happen anyway when these get merged by the "Pointing Fingers: Deduplicating Entity APIs with EntityPtr" working group, so this is fine for now!
…ilteredEntity{Ref,Mut}.
anlumo
force-pushed
the
entityrefexcept-componentid
branch
from
7adeefe to
161ca26
Compare
|
@chescock I reverted the unsound lifetime change by an amend commit, apparently that removes the entire conversation from GitHub. Everything seems to be fine, so the issues I was having apparently were solved by some other change during development. |
chescock
approved these changes
Feb 12, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
pushed a commit
to alice-i-cecile/bevy
that referenced
this pull request
Feb 12, 2025
…ilteredEntity{Ref,Mut} (bevyengine#17800)
# Objective
Related to bevyengine#17784. The ticket is actually about just getting rid of
`Entity{Ref,Mut}Except` in favor of `FilteredEntity{Ref,Mut}`, but I got
told the unification of Entity types is a bigger endeavor that has been
going on for a while now (as the "Pointing Fingers" working group) and I
should just add the functions I actually need in the meantime.
## Solution
This PR adds all of the functions necessary to access components by
TypeId or ComponentId instead of static types.
## Testing
> Did you test these changes? If so, how?
Haven't tested it yet, but the changes are mostly copy/paste from other
implementations in the same file, since there is a lot of duplicated
functionality there.
## Not a Migration Guide
There shouldn't be any breaking changes, it's just a few new functions
on existing types.
I had to shuffle around the lifetimes in `From<&EntityMutExcept<'a, B>>
for EntityRefExcept<'a, B>` (originally it was `From<&'a
EntityMutExcept<'_, B>> for EntityRefExcept<'_, B>`) to make the borrow
checker happy, but I don't think that this should have an impact on user
code (correct me if I'm wrong).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Related to #17784. The ticket is actually about just getting rid of
Entity{Ref,Mut}Exceptin favor ofFilteredEntity{Ref,Mut}, but I got told the unification of Entity types is a bigger endeavor that has been going on for a while now (as the "Pointing Fingers" working group) and I should just add the functions I actually need in the meantime.Solution
This PR adds all of the functions necessary to access components by TypeId or ComponentId instead of static types.
Testing
Haven't tested it yet, but the changes are mostly copy/paste from other implementations in the same file, since there is a lot of duplicated functionality there.
Not a Migration Guide
There shouldn't be any breaking changes, it's just a few new functions on existing types.