bevy_reflect: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)]
#17092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttributes_without_reason)]` to `bevy_reflect`
IQuick143
added
C-Code-Quality
BenjaminBrienen
suggested changes
Jan 2, 2025
| #![allow(unused_qualifications)] | ||
| #
There was a problem hiding this comment.
I don't understand the parenthesis here
There was a problem hiding this comment.
Yeah, I'd like to clean this up before merging. @MrGVSV, what did you mean here?
There was a problem hiding this comment.
This actually wasn't me. Looks like it was added in #14828. My guess is that since Option and Result are in the prelude, their full qualification is unnecessary, but we rely on it for generating the TypePath impl within impl_reflect!.
| @@ -199,7 +199,7 @@ mod tests { | |||
|
|
|||
| #[reflect_trait] | |||
| trait Enemy: Reflect + Debug { | |||
| #[allow(dead_code, reason = "this method is purely for testing purposes")] | |||
| #[expect(dead_code, reason = "this method is purely for testing purposes")] | |||
There was a problem hiding this comment.
This method may become used during said testing, and it would be annoying if this generated a warning during testing.
There was a problem hiding this comment.
I think I prefer leaving this as an expect for now.
alice-i-cecile
added
S-Needs-Help
2 tasks
BenjaminBrienen
approved these changes
Jan 3, 2025
alice-i-cecile
approved these changes
Jan 3, 2025
LikeLakers2
deleted the
lint/deny_allow_and_without_reason/bevy_reflect
branch
LikeLakers2
changed the title
#[deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)]#![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)]
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
…ttributes_without_reason)]` (bevyengine#17092) # Objective We want to deny the following lints: * `clippy::allow_attributes` - Because there's no reason to `#[allow(...)]` an attribute if it wouldn't lint against anything; you should always use `#[expect(...)]` * `clippy::allow_attributes_without_reason` - Because documenting the reason for allowing/expecting a lint is always good ## Solution Set the `clippy::allow_attributes` and `clippy::allow_attributes_without_reason` lints to `deny`, and bring `bevy_reflect` in line with the new restrictions. No code changes have been made - except if a lint that was previously `allow(...)`'d could be removed via small code changes. For example, `unused_variables` can be handled by adding a `_` to the beginning of a field's name. ## Testing I ran `cargo clippy`, and received no errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
We want to deny the following lints:
clippy::allow_attributes- Because there's no reason to#[allow(...)]an attribute if it wouldn't lint against anything; you should always use#[expect(...)]clippy::allow_attributes_without_reason- Because documenting the reason for allowing/expecting a lint is always goodSolution
Set the
clippy::allow_attributesandclippy::allow_attributes_without_reasonlints todeny, and bringbevy_reflectin line with the new restrictions.No code changes have been made - except if a lint that was previously
allow(...)'d could be removed via small code changes. For example,unused_variablescan be handled by adding a_to the beginning of a field's name.Testing
I ran
cargo clippy, and received no errors.