Rust 1.83, allow -> expect (missing_docs) #16561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see what the CI has to say now 👀 |
BenjaminBrienen
suggested changes
Nov 30, 2024
|
I think you can use expect there if you use cfg_attr. |
bas-ie
added
C-Docs
BenjaminBrienen
suggested changes
Nov 30, 2024
BenjaminBrienen
approved these changes
Nov 30, 2024
BenjaminBrienen
approved these changes
Nov 30, 2024
BD103
reviewed
Dec 13, 2024
BD103
added
S-Waiting-on-Author
bas-ie
added
S-Needs-Review
BD103
added
S-Ready-For-Final-Review
BenjaminBrienen
approved these changes
Dec 16, 2024
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective We were waiting for 1.83 to address most of these, due to a bug with `missing_docs` and `expect`. Relates to, but does not entirely complete, bevyengine#15059. ## Solution - Upgrade to 1.83 - Switch `allow(missing_docs)` to `expect(missing_docs)` - Remove a few now-unused `allow`s along the way, or convert to `expect`
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective We were waiting for 1.83 to address most of these, due to a bug with `missing_docs` and `expect`. Relates to, but does not entirely complete, bevyengine#15059. ## Solution - Upgrade to 1.83 - Switch `allow(missing_docs)` to `expect(missing_docs)` - Remove a few now-unused `allow`s along the way, or convert to `expect`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
We were waiting for 1.83 to address most of these, due to a bug with
missing_docsandexpect. Relates to, but does not entirely complete, #15059.Solution
allow(missing_docs)toexpect(missing_docs)allows along the way, or convert toexpect