Skip to content

Simple integration testing (adopted) #16489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 24, 2024

Conversation

bas-ie
Copy link
Contributor

@bas-ie bas-ie commented Nov 23, 2024

Objective

This older PR from Wcubed seemed well worth saving, adopted from #7314. See also tracking issue #2896 for ongoing discussion of Bevy testability. Thanks Wcubed!

Solution

  • Updated for 0.15
  • Added the expected/actual pattern
  • Switched to function plugin
  • Tweaked a bit of description

Testing

Green.

@bas-ie bas-ie added C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 23, 2024
@Wcubed
Copy link
Contributor

Wcubed commented Nov 23, 2024

Thanks for adopting the pr 😃. I'd almost forgotten I made this one after two years 😄.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call: I do really like this! Straightforward and useful. There's a nit to be fixed about doc comments, but I'm happy to approve this after that.

Copy link
Contributor

@BenjaminBrienen BenjaminBrienen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be super useful!

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged A-Cross-Cutting Impacts the entire engine C-Examples An addition or correction to our examples and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 24, 2024
@bas-ie bas-ie added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Nov 24, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 24, 2024
Merged via the queue into bevyengine:main with commit bb81a2c Nov 24, 2024
28 checks passed
@bas-ie bas-ie deleted the integration-test-examples branch November 24, 2024 23:01
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
# Objective

This older PR from `Wcubed` seemed well worth saving, adopted from
bevyengine#7314. See also tracking issue bevyengine#2896 for ongoing discussion of Bevy
testability. Thanks `Wcubed`!

## Solution

- Updated for 0.15
- Added the `expected`/`actual` pattern
- Switched to function plugin
- Tweaked a bit of description

## Testing

Green.

---------

Co-authored-by: Wybe Westra <[email protected]>
Co-authored-by: Wybe Westra <[email protected]>
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
# Objective

This older PR from `Wcubed` seemed well worth saving, adopted from
bevyengine#7314. See also tracking issue bevyengine#2896 for ongoing discussion of Bevy
testability. Thanks `Wcubed`!

## Solution

- Updated for 0.15
- Added the `expected`/`actual` pattern
- Switched to function plugin
- Tweaked a bit of description

## Testing

Green.

---------

Co-authored-by: Wybe Westra <[email protected]>
Co-authored-by: Wybe Westra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Cross-Cutting Impacts the entire engine C-Examples An addition or correction to our examples C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants